Issue 6341149593698304: Issue 301 - Change for each to for .. of .. in lib/

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6341149593698304: Issue 301 - Change for each to for .. of .. in lib/ (Closed)

Created:
April 10, 2014, 5:02 p.m. by tschuster

Modified:
April 14, 2014, 6 p.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Change for each to for .. of .. in lib/

Created: April 10, 2014, 5:02 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -50 lines)			Patch
M	lib/Public.jsm	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	lib/antiadblockInit.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/contentPolicy.js	View	6 chunks	+7 lines, -7 lines	0 comments	Download
M	lib/downloader.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/filterClasses.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/filterListener.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/filterNotifier.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/filterStorage.js	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	lib/notification.js	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	lib/objectTabs.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/requestNotifier.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/subscriptionClasses.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/sync.js	View	6 chunks	+12 lines, -12 lines	0 comments	Download
M	lib/synchronizer.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/ui.js	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/utils.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2

Wladimir Palant

April 11, 2014, 5:47 a.m. (2014-04-11 05:47:00 UTC) #2

LGTM

Please note that the unit tests extension
(https://hg.adblockplus.org/adblockplustests/) needs updating as well.