Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 6380170118168576: Issue 2277 - Use the new notification.json handler (Closed)

Created:
April 12, 2015, 11:02 p.m. by Felix Dahlke
Modified:
June 29, 2015, 12:54 p.m.
Reviewers:
mathias
CC:
Sebastian Noack, Wladimir Palant
Visibility:
Public.

Description

Issue 2277 - Use the new notification.json handler

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -31 lines) Patch
M modules/notificationserver/files/site.conf View 1 chunk +10 lines, -2 lines 0 comments Download
M modules/notificationserver/files/sitescripts.ini View 1 chunk +3 lines, -1 line 0 comments Download
M modules/notificationserver/manifests/init.pp View 2 chunks +18 lines, -28 lines 3 comments Download
A modules/notificationserver/templates/global.conf.erb View 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 5
Felix Dahlke
http://codereview.adblockplus.org/6380170118168576/diff/5629499534213120/modules/notificationserver/manifests/init.pp File modules/notificationserver/manifests/init.pp (right): http://codereview.adblockplus.org/6380170118168576/diff/5629499534213120/modules/notificationserver/manifests/init.pp#newcode49 modules/notificationserver/manifests/init.pp:49: global_config => template('notificationserver/global.conf.erb'), I don't actually need a template ...
April 12, 2015, 11:05 p.m. (2015-04-12 23:05:11 UTC) #1
Felix Dahlke
April 12, 2015, 11:05 p.m. (2015-04-12 23:05:13 UTC) #2
mathias
http://codereview.adblockplus.org/6380170118168576/diff/5629499534213120/modules/notificationserver/manifests/init.pp File modules/notificationserver/manifests/init.pp (right): http://codereview.adblockplus.org/6380170118168576/diff/5629499534213120/modules/notificationserver/manifests/init.pp#newcode25 modules/notificationserver/manifests/init.pp:25: package {'python-flup':} OK for now, but please see https://issues.adblockplus.org/ticket/2313 ...
April 14, 2015, 5:12 a.m. (2015-04-14 05:12:20 UTC) #3
Felix Dahlke
http://codereview.adblockplus.org/6380170118168576/diff/5629499534213120/modules/notificationserver/templates/global.conf.erb File modules/notificationserver/templates/global.conf.erb (right): http://codereview.adblockplus.org/6380170118168576/diff/5629499534213120/modules/notificationserver/templates/global.conf.erb#newcode5 modules/notificationserver/templates/global.conf.erb:5: ~(?<1>-.*) $1; On 2015/04/14 05:12:20, matze wrote: > Why ...
April 14, 2015, 5:18 a.m. (2015-04-14 05:18:25 UTC) #4
mathias
April 14, 2015, 5:38 a.m. (2015-04-14 05:38:59 UTC) #5 
LGTM.

Powered by Google App Engine
This is Rietveld