Issue 6389439060246528: Issue 2186 - Integrate Django fixture upload with Rietveld

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6389439060246528: Issue 2186 - Integrate Django fixture upload with Rietveld (Closed)

Created:
March 20, 2015, 11:28 a.m. by mathias

Modified:
March 22, 2015, 12:10 a.m.

Reviewers:
Felix Dahlke

CC:
Wladimir Palant

Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/2186 --

Patch Set 2 : Issue 2186 - Integrate Django fixture upload with Rietveld #

Total comments: 2

Created: March 20, 2015, 12:43 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -1 line)			Patch
	M	modules/rietveld/manifests/init.pp	View	1	2 chunks	+43 lines, -1 line	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mathias

A tiny update aligned with https://issues.adblockplus.org/ticket/2188 --

March 20, 2015, 12:43 p.m. (2015-03-20 12:43:34 UTC) #2

Felix Dahlke

LGTM, but please see my comment. http://codereview.adblockplus.org/6389439060246528/diff/5741031244955648/modules/rietveld/manifests/init.pp File modules/rietveld/manifests/init.pp (right): http://codereview.adblockplus.org/6389439060246528/diff/5741031244955648/modules/rietveld/manifests/init.pp#newcode123 modules/rietveld/manifests/init.pp:123: present => Exec[$destination], ...

March 21, 2015, 9:08 p.m. (2015-03-21 21:08:52 UTC) #3

mathias

March 21, 2015, 11:16 p.m. (2015-03-21 23:16:47 UTC) #4

http://codereview.adblockplus.org/6389439060246528/diff/5741031244955648/modu...
File modules/rietveld/manifests/init.pp (right):

http://codereview.adblockplus.org/6389439060246528/diff/5741031244955648/modu...
modules/rietveld/manifests/init.pp:123: present => Exec[$destination],
On 2015/03/21 21:08:52, Felix H. Dahlke wrote:
> So, when the fixture changes, the loaddata call is happening again, right?
I'll
> assume this works as expected, i.e. replacing the data.

Indeed it does. Of course this is still not meant for maintaining the entire
database, it's more a bootstrap mechanism.

Expand All Messages | Collapse All Messages