Issue 2610 - Return notification version in a response header

Issue 2610 - Return notification version in a response header

[Felix Dahlke, 2015-05-30 20:37:07]

This patch is based on http://codereview.adblockplus.org/4883267715072000/,
which hasn't landed yet.

http://codereview.adblockplus.org/6402627529080832/diff/5629499534213120/site...
File sitescripts/notifications/test/notification.py (right):

http://codereview.adblockplus.org/6402627529080832/diff/5629499534213120/site...
sitescripts/notifications/test/notification.py:309: for name, value in
response_headers:
Suggestions for a simpler way welcome - feels pretty hacky to me.

[Sebastian Noack, 2015-06-02 22:35:47]

http://codereview.adblockplus.org/6402627529080832/diff/5629499534213120/site...
File sitescripts/notifications/test/notification.py (right):

http://codereview.adblockplus.org/6402627529080832/diff/5629499534213120/site...
sitescripts/notifications/test/notification.py:309: for name, value in
response_headers:
On 2015/05/30 20:37:07, Felix H. Dahlke wrote:
> Suggestions for a simpler way welcome - feels pretty hacky to me.

Not much simpler, but here you go:

  response_header_map = None
  def start_response(status, response_headers):
    response_header_map = dict(response_headers)

[Felix Dahlke, 2015-06-03 03:21:07]

http://codereview.adblockplus.org/6402627529080832/diff/5629499534213120/site...
File sitescripts/notifications/test/notification.py (right):

http://codereview.adblockplus.org/6402627529080832/diff/5629499534213120/site...
sitescripts/notifications/test/notification.py:309: for name, value in
response_headers:
On 2015/06/02 22:35:47, Sebastian Noack wrote:
> On 2015/05/30 20:37:07, Felix H. Dahlke wrote:
> > Suggestions for a simpler way welcome - feels pretty hacky to me.
> 
> Not much simpler, but here you go:
> 
>   response_header_map = None
>   def start_response(status, response_headers):
>     response_header_map = dict(response_headers)

I've tried this before - unfortunately it doesn't work because I cannot assign
to a variable from the parent scope, apparently. That's why I'm initialising the
dict in the parent scope and just add elements to it in the function, but it
feels like a hack.

[Sebastian Noack, 2015-06-03 08:34:58]

LGTM

http://codereview.adblockplus.org/6402627529080832/diff/5629499534213120/site...
File sitescripts/notifications/test/notification.py (right):

http://codereview.adblockplus.org/6402627529080832/diff/5629499534213120/site...
sitescripts/notifications/test/notification.py:309: for name, value in
response_headers:
On 2015/06/03 03:21:07, Felix H. Dahlke wrote:
> On 2015/06/02 22:35:47, Sebastian Noack wrote:
> > On 2015/05/30 20:37:07, Felix H. Dahlke wrote:
> > > Suggestions for a simpler way welcome - feels pretty hacky to me.
> > 
> > Not much simpler, but here you go:
> > 
> >   response_header_map = None
> >   def start_response(status, response_headers):
> >     response_header_map = dict(response_headers)
> 
> I've tried this before - unfortunately it doesn't work because I cannot assign
> to a variable from the parent scope, apparently. That's why I'm initialising
the
> dict in the parent scope and just add elements to it in the function, but it
> feels like a hack.

Alright, that it's actually True. Variables are always set locally unless
declared otherwise. However, in Python 2 there is only a "global" keyword, but
here you would need the "nonlocal" keyword introduced in Python 3.