Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6421494749986816: Issue 1659 - GPL 3 license to our French homepage (Websites) (Closed)

Created:
Dec. 9, 2014, 5:22 p.m. by saroyanm
Modified:
Jan. 15, 2015, 12:40 p.m.
Visibility:
Public.

Description

This review is related to current ticket: https://issues.adblockplus.org/ticket/1659 Infrastructure: http://codereview.adblockplus.org/5513912812306432/

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M index.html View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
saroyanm
Thomas can you please have a look. http://codereview.adblockplus.org/6421494749986816/diff/5629499534213120/index.html File index.html (right): http://codereview.adblockplus.org/6421494749986816/diff/5629499534213120/index.html#newcode25 index.html:25: <span class="gpl-license ...
Dec. 9, 2014, 5:31 p.m. (2014-12-09 17:31:54 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/6421494749986816/diff/5629499534213120/index.html File index.html (right): http://codereview.adblockplus.org/6421494749986816/diff/5629499534213120/index.html#newcode25 index.html:25: <span class="gpl-license lang-fr">(<a href="​https://www.gnu.org/licenses/translations.fr.html"><fix>Licence GPLv3</fix></a>)</span> Please put the <fix> ...
Dec. 9, 2014, 8:37 p.m. (2014-12-09 20:37:33 UTC) #2
saroyanm
http://codereview.adblockplus.org/6421494749986816/diff/5629499534213120/index.html File index.html (right): http://codereview.adblockplus.org/6421494749986816/diff/5629499534213120/index.html#newcode25 index.html:25: <span class="gpl-license lang-fr">(<a href="​https://www.gnu.org/licenses/translations.fr.html"><fix>Licence GPLv3</fix></a>)</span> On 2014/12/09 20:37:33, Wladimir ...
Dec. 10, 2014, 6:43 a.m. (2014-12-10 06:43:15 UTC) #3
Thomas Greiner
Not sure why the link is (sometimes) not correctly interpreted in the local environment but ...
Dec. 10, 2014, 10:15 a.m. (2014-12-10 10:15:51 UTC) #4
saroyanm
On 2014/12/10 10:15:51, Thomas Greiner wrote: > Not sure why the link is (sometimes) not ...
Jan. 7, 2015, 1:16 p.m. (2015-01-07 13:16:40 UTC) #5
Wladimir Palant
Jan. 15, 2015, 12:40 p.m. (2015-01-15 12:40:37 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld