Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6423769060999168: Issue 301 - adblockplustests: Use for (.. of ..) (Closed)

Created:
April 12, 2014, 1:48 p.m. by tschuster
Modified:
April 14, 2014, 6 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Running the tests seems to work, so this should be fine. The buildtools subrepo needs to be updated

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M chrome/content/common.js View 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/content/index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/tests/elemhide.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/tests/filterClasses.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/content/tests/filterListener.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/content/tests/filterNotifier.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/tests/filterStorage_readwrite.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/content/tests/matcher.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/content/tests/notification.js View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/content/tests/performance/common.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/tests/performance/filter_fromText.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/tests/performance/matcher_init.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/tests/performance/matching.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/content/tests/performance/page_load_overhead.html View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/content/tests/popupBlocker.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/tests/subscriptionClasses.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/tests/synchronizer.js View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/content/tests/test_requestList.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
tschuster
April 12, 2014, 1:49 p.m. (2014-04-12 13:49:01 UTC) #1
Wladimir Palant
April 12, 2014, 8:44 p.m. (2014-04-12 20:44:21 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld