Issue 328 - ABP doesn't respect the system locale when adding a filter list

Issue 328 - ABP doesn't respect the system locale when adding a filter list

[René Jeschke, 2014-06-11 08:53:24]

Workaround for issue 328:

The real problem is that e.g. '^de\\b' doesn't match 'de_DE' but 'de-DE'. So we
should also replace the regex in libadblockplus with something more accurate.

(Like: "^de(\\s|\\_|-)[a-zA-Z]{2}" which will match any possible combination for
more or less valid locales).

[Felix Dahlke, 2014-06-12 10:35:19]

libadblockplus uses Mozilla's locale format
(https://wiki.mozilla.org/L10n:Locale_Codes), which differs from Java's in more
ways than just s/_/-/. We should probably check the differences and do a proper
translation, similar to how we map between Firefox and Chrome locales in
buildtools.

On 2014/06/11 08:53:24, René Jeschke wrote:
> Workaround for issue 328:
> 
> The real problem is that e.g. '^de\\b' doesn't match 'de_DE' but 'de-DE'. So
we
> should also replace the regex in libadblockplus with something more accurate.
> 
> (Like: "^de(\\s|\\_|-)[a-zA-Z]{2}" which will match any possible combination
for
> more or less valid locales).

[Felix Dahlke, 2014-06-12 10:52:53]

LGTM. As discussed on IRC, this should be good enough.

It seems the only downside of not doing a comprehensive translation of country
codes between the formats is that we'll fall back on the canonical language
variant for filter list selection in some edge cases.