Issues #276, #1163 - introduce class IncomingParam

Issues #276, #1163 - introduce class IncomingParam

New class IncomingParam. Eliminate all uses of ATL::CComBSTR when it appears as
the receiver of an incoming parameter from a COM entry point. Constructor 
has its final signature. Convertible predicate and non-throwing conversion
function are transient during work on #1163.

[Eric, 2014-07-25 23:30:12]

Follows http://codereview.adblockplus.org/5070706781978624/ because of tool
limitations. This is the other half of eliminating CComBSTR

[sergei, 2014-07-28 09:24:31]

http://codereview.adblockplus.org/6650591174459392/diff/5629499534213120/src/...
File src/plugin/COM_Value.h (right):

http://codereview.adblockplus.org/6650591174459392/diff/5629499534213120/src/...
src/plugin/COM_Value.h:137: Incoming_Param( BSTR b );
Instead of commenting all bad things here, I will say only the desired result.
Replace this class by the method
`std::wstring our-namespace::to_wstring(const BSTR value)`.

[Eric, 2014-07-29 19:53:08]

Note changed issue description.

http://codereview.adblockplus.org/6650591174459392/diff/5629499534213120/src/...
File src/plugin/COM_Value.h (right):

http://codereview.adblockplus.org/6650591174459392/diff/5629499534213120/src/...
src/plugin/COM_Value.h:137: Incoming_Param( BSTR b );
On 2014/07/28 09:24:31, sergei wrote:
> Instead of commenting all bad things here, I will say only the desired result.
> Replace this class by the method
> `std::wstring our-namespace::to_wstring(const BSTR value)`.

Oh, that's just awful. If there's one thing I've learned about dealing with COM
interface types, it's that conversion functions that ignore their lifecycle
issues are a Very Bad Idea. Using a generic name for a conversion function is
asking for trouble.

Whatever. This was supposed to be a temporary class anyway, as the comment very
clearly indicated. I've just rewritten the whole thing as I was going to get to
later.

[Oleksandr, 2014-10-07 22:02:35]

Bump. Shall we close this?
On 2014/07/29 19:53:08, Eric wrote:
> Note changed issue description.
> 
>
http://codereview.adblockplus.org/6650591174459392/diff/5629499534213120/src/...
> File src/plugin/COM_Value.h (right):
> 
>
http://codereview.adblockplus.org/6650591174459392/diff/5629499534213120/src/...
> src/plugin/COM_Value.h:137: Incoming_Param( BSTR b );
> On 2014/07/28 09:24:31, sergei wrote:
> > Instead of commenting all bad things here, I will say only the desired
result.
> > Replace this class by the method
> > `std::wstring our-namespace::to_wstring(const BSTR value)`.
> 
> Oh, that's just awful. If there's one thing I've learned about dealing with
COM
> interface types, it's that conversion functions that ignore their lifecycle
> issues are a Very Bad Idea. Using a generic name for a conversion function is
> asking for trouble.
> 
> Whatever. This was supposed to be a temporary class anyway, as the comment
very
> clearly indicated. I've just rewritten the whole thing as I was going to get
to
> later.