Issue 1227 - Could not close the info-text

src/org/adblockplus/android/AboutDialog.java

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.android;
 
 import android.app.Dialog;
 import android.content.Context;
 import android.content.pm.PackageInfo;
 import android.content.pm.PackageManager.NameNotFoundException;
 import android.os.Bundle;
 import android.text.Html;
 import android.text.method.LinkMovementMethod;
 import android.view.View;
-import android.view.View.OnClickListener;
 import android.view.Window;
 import android.widget.Button;
 import android.widget.TextView;
 
-public class AboutDialog extends Dialog implements OnClickListener
+public class AboutDialog extends Dialog
 {
   private static Context context = null;
 
   public AboutDialog(final Context context)
   {
     super(context);
     AboutDialog.context = context;
   }
 
   @Override
@@ skipping 32 matching lines @@
     info.append("</p>");
     AdblockPlus.appendRawTextFile(context, info, R.raw.info);
     AdblockPlus.appendRawTextFile(context, info, R.raw.legal);
 
     // Show text
     final TextView tv = (TextView) findViewById(R.id.about_text);
     tv.setText(Html.fromHtml(info.toString()));
     tv.setMovementMethod(LinkMovementMethod.getInstance());
 
     final Button okButton = (Button) findViewById(R.id.close_about);
-    okButton.setOnClickListener(this);

[Felix Dahlke, 2014/11/11 09:30:43]

Not a particular fan of this pattern, gets messy pretty fast if there's more
than one handler. Why not just go with an anonymous class?

-  }
-
-  @Override
-  public void onClick(View v)
-  {
-    this.dismiss();
+    okButton.setOnClickListener(new View.OnClickListener()
+    {
+      @Override
+      public void onClick(View v)
+      {
+        AboutDialog.this.dismiss();
+      }
+    });
   }
 }