Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 6731909971312640: Issue 1227 - Could not close the info-text (Closed)

Created:
Nov. 6, 2014, 12:49 p.m. by René Jeschke
Modified:
Nov. 17, 2014, 4 p.m.
Reviewers:
Felix Dahlke
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 1227 - Could not close the info-text

Patch Set 1 #

Total comments: 1

Patch Set 2 : Switched to anonymous inner class for OnClickListener #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M res/layout/about.xml View 1 chunk +13 lines, -0 lines 0 comments Download
M src/org/adblockplus/android/AboutDialog.java View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4
René Jeschke
Nov. 6, 2014, 1:41 p.m. (2014-11-06 13:41:23 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/6731909971312640/diff/5629499534213120/src/org/adblockplus/android/AboutDialog.java File src/org/adblockplus/android/AboutDialog.java (right): http://codereview.adblockplus.org/6731909971312640/diff/5629499534213120/src/org/adblockplus/android/AboutDialog.java#newcode86 src/org/adblockplus/android/AboutDialog.java:86: okButton.setOnClickListener(this); Not a particular fan of this pattern, gets ...
Nov. 11, 2014, 9:30 a.m. (2014-11-11 09:30:43 UTC) #2
René Jeschke
On 2014/11/11 09:30:43, Felix H. Dahlke wrote: > http://codereview.adblockplus.org/6731909971312640/diff/5629499534213120/src/org/adblockplus/android/AboutDialog.java > File src/org/adblockplus/android/AboutDialog.java (right): > > ...
Nov. 11, 2014, 11:29 a.m. (2014-11-11 11:29:31 UTC) #3
Felix Dahlke
Nov. 13, 2014, 9:02 a.m. (2014-11-13 09:02:44 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld