Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8358150: Crash submission backend (Closed)

Created:
Sept. 17, 2012, 2:47 p.m. by Andrey Novikov
Modified:
Sept. 18, 2012, 8:20 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Crash submission backend

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, --2 lines) Patch
A sitescripts/crashes/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A sitescripts/crashes/web/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A sitescripts/crashes/web/submitCrash.py View 1 chunk +55 lines, -0 lines 4 comments Download
M sitescripts/web.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
Andrey Novikov
Sept. 17, 2012, 2:52 p.m. (2012-09-17 14:52:34 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/8358150/diff/1/sitescripts/crashes/web/submitCrash.py File sitescripts/crashes/web/submitCrash.py (right): http://codereview.adblockplus.org/8358150/diff/1/sitescripts/crashes/web/submitCrash.py#newcode41 sitescripts/crashes/web/submitCrash.py:41: file = os.fdopen(fd, 'w') 'wb' please, we don't want ...
Sept. 17, 2012, 3:15 p.m. (2012-09-17 15:15:16 UTC) #2
Andrey Novikov
Sept. 17, 2012, 3:33 p.m. (2012-09-17 15:33:23 UTC) #3
http://codereview.adblockplus.org/8358150/diff/1/sitescripts/crashes/web/subm...
File sitescripts/crashes/web/submitCrash.py (right):

http://codereview.adblockplus.org/8358150/diff/1/sitescripts/crashes/web/subm...
sitescripts/crashes/web/submitCrash.py:41: file = os.fdopen(fd, 'w')
On 2012/09/17 15:15:16, Wladimir Palant wrote:
> 'wb' please, we don't want the data to be changed.

Done.

http://codereview.adblockplus.org/8358150/diff/1/sitescripts/crashes/web/subm...
sitescripts/crashes/web/submitCrash.py:44: os.rename(filename, filename[:-4]);
On 2012/09/17 15:15:16, Wladimir Palant wrote:
> Please use os.path.splitext(), this will make the code more obvious.

Done.

Powered by Google App Engine
This is Rietveld