Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8432040: Provide access to the File object (Closed)

Created:
Sept. 25, 2012, 3:11 p.m. by Felix Dahlke
Modified:
Sept. 26, 2012, 8:19 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

As discussed, I've made the File object available to lib code.

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M bootstrap.js.tmpl View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
Felix Dahlke
Sept. 25, 2012, 3:12 p.m. (2012-09-25 15:12:44 UTC) #1
Wladimir Palant
http://codereview.adblockplus.org/8432040/diff/1/bootstrap.js.tmpl File bootstrap.js.tmpl (right): http://codereview.adblockplus.org/8432040/diff/1/bootstrap.js.tmpl#newcode12 bootstrap.js.tmpl:12: let {Services, atob, btoa, File} = Cu.import("resource://gre/modules/Services.jsm", null); Just ...
Sept. 25, 2012, 3:21 p.m. (2012-09-25 15:21:41 UTC) #2
Felix Dahlke
Okay, fixed.
Sept. 26, 2012, 8:10 a.m. (2012-09-26 08:10:04 UTC) #3
Wladimir Palant
Sept. 26, 2012, 8:15 a.m. (2012-09-26 08:15:09 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld