Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8432103: Proper Fennec support (Closed)

Created:
Sept. 28, 2012, 7:18 a.m. by Wladimir Palant
Modified:
Nov. 21, 2012, 4:33 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Proper Fennec support

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -102 lines) Patch
M lib/appIntegration.js View 4 chunks +80 lines, -94 lines 1 comment Download
M lib/hooks.js View 1 chunk +19 lines, -5 lines 0 comments Download
M lib/typoFixer.js View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
Sept. 28, 2012, 7:18 a.m. (2012-09-28 07:18:52 UTC) #1
Thomas Greiner
Sept. 28, 2012, 8:20 a.m. (2012-09-28 08:20:13 UTC) #2
OK

http://codereview.adblockplus.org/8432103/diff/1/lib/appIntegration.js
File lib/appIntegration.js (right):

http://codereview.adblockplus.org/8432103/diff/1/lib/appIntegration.js#newcode18
lib/appIntegration.js:18: let {application} = require("info");
please move that up to where hook and functionHooks are initialized

Powered by Google App Engine
This is Rietveld