Reimplemented whitelist handling

Reimplemented whitelist handling

[Thomas Greiner, 2012-09-26 15:49:13]

OK. I'd suggest some smaller changes but I didn't find any problems with the
code itself.

I like the comments inside the addSuffix and removeSuffix functions.

http://codereview.adblockplus.org/8450003/diff/1/chrome/content/tests/tests/s...
File chrome/content/tests/tests/suffixTreeManipulation.js (right):

http://codereview.adblockplus.org/8450003/diff/1/chrome/content/tests/tests/s...
chrome/content/tests/tests/suffixTreeManipulation.js:2: {
bracket on first line (as seen on last line)

http://codereview.adblockplus.org/8450003/diff/1/chrome/content/tests/tests/s...
chrome/content/tests/tests/suffixTreeManipulation.js:10: let addonID =
"{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}"
semicolon is missing

http://codereview.adblockplus.org/8450003/diff/1/lib/rules.js
File lib/rules.js (right):

http://codereview.adblockplus.org/8450003/diff/1/lib/rules.js#newcode105
lib/rules.js:105: let reverse =
Array.prototype.slice.call(domain).reverse().join("");
It looks less confusing if you do it this way:

let reverse = domain.slice().reverse().join("");

[Thomas Greiner, 2012-09-26 15:59:35]

http://codereview.adblockplus.org/8450003/diff/1/lib/rules.js
File lib/rules.js (right):

http://codereview.adblockplus.org/8450003/diff/1/lib/rules.js#newcode98
lib/rules.js:98: let reverse =
Array.prototype.slice.call(domain).reverse().join("");
On 2012/09/26 15:49:13, Thomas Greiner wrote:
> It looks less confusing if you do it this way:
> 
> let reverse = domain.slice().reverse().join("");

also in onWhitelistEntryAdded function

[Wladimir Palant, 2012-09-27 14:55:06]

http://codereview.adblockplus.org/8450003/diff/1/chrome/content/tests/tests/s...
File chrome/content/tests/tests/suffixTreeManipulation.js (right):

http://codereview.adblockplus.org/8450003/diff/1/chrome/content/tests/tests/s...
chrome/content/tests/tests/suffixTreeManipulation.js:2: {
On 2012/09/26 15:49:13, Thomas Greiner wrote:
> bracket on first line (as seen on last line)

Not really how I usually write it...

http://codereview.adblockplus.org/8450003/diff/1/chrome/content/tests/tests/s...
chrome/content/tests/tests/suffixTreeManipulation.js:10: let addonID =
"{d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}"
On 2012/09/26 15:49:13, Thomas Greiner wrote:
> semicolon is missing

Bigger issue actually - that's the ID for Adblock Plus, not URL Fixer.

http://codereview.adblockplus.org/8450003/diff/1/lib/rules.js
File lib/rules.js (right):

http://codereview.adblockplus.org/8450003/diff/1/lib/rules.js#newcode105
lib/rules.js:105: let reverse =
Array.prototype.slice.call(domain).reverse().join("");
On 2012/09/26 15:49:13, Thomas Greiner wrote:
> It looks less confusing if you do it this way:
> 
> let reverse = domain.slice().reverse().join("");

domain is a string - string.slice() returns another string, no reverse()
function there. But you probably meant split("").

[Thomas Greiner, 2012-09-28 08:02:36]

OK