Slight improvements to URL Fixer code

Slight improvements to URL Fixer code

[Thomas Greiner, 2012-10-02 10:31:14]

infobar shows up too often due to removed code

http://codereview.adblockplus.org/8478020/diff/1/lib/typoFixer.js
File lib/typoFixer.js (left):

http://codereview.adblockplus.org/8478020/diff/1/lib/typoFixer.js#oldcode188
lib/typoFixer.js:188: return Prefs.custom_replace[value];
Feel free to modify it but don't remove this code. There needs to be a return or
otherwise the infobar shows up after a correction which has been made based on a
rule that was explicitly declared by the user.

Also if you remove that code there's no use for custom_rules anymore because
they seem to be not used anywhere else.

[Wladimir Palant, 2012-10-05 10:19:55]

As discussed on IRC, we still want to make infobar show up when the redirection
is the result of custom rules. A user doesn't necessarily remember that he added
a custom rule, also both custom rules and usual corrections could be applied.

A slight issue is that clicking "No" will still add an exception - but that
doesn't disable the custom rule, the user will still be redirected. It is
unclear whether there is a better solution here but the issue is minor.