Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8492018: abpcrawler: Collect unmatched filters (Closed)

Created:
Oct. 2, 2012, 5:01 a.m. by Felix Dahlke
Modified:
Dec. 22, 2012, 5:56 a.m.
Reviewers:
Eric, Wladimir Palant
Visibility:
Public.

Description

I've made the crawler send data on matched filters and updated it for some other changes made in sitescripts for that purpose.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -18 lines) Patch
M lib/client.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/crawler.js View 4 chunks +41 lines, -13 lines 3 comments Download
M lib/storage.js View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
LGTM but the comment might be worth addressing nevertheless. http://codereview.adblockplus.org/8492018/diff/1/lib/crawler.js File lib/crawler.js (right): http://codereview.adblockplus.org/8492018/diff/1/lib/crawler.js#newcode24 lib/crawler.js:24: ...
Dec. 13, 2012, 4:14 p.m. (2012-12-13 16:14:01 UTC) #1
Felix Dahlke
Not entirely sure if I can safely merge this without merging 8492019 at the same ...
Dec. 14, 2012, 10:11 a.m. (2012-12-14 10:11:58 UTC) #2
Wladimir Palant
If the only relevant change in 8492019 is the different backend URL then why not ...
Dec. 14, 2012, 4:43 p.m. (2012-12-14 16:43:01 UTC) #3
Felix Dahlke
I've added Eric as a reviewer. Eric, this is some unmerged code to send the ...
Dec. 19, 2012, 4:22 p.m. (2012-12-19 16:22:13 UTC) #4
Eric
Dec. 20, 2012, 4:53 p.m. (2012-12-20 16:53:15 UTC) #5
Go ahead and commit this. I haven't started working with this code yet, and I'd
prefer to have your most recent working version.

Powered by Google App Engine
This is Rietveld