Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 8554013: Renamed necessary components for ABP integration (Closed)

Created:
Oct. 10, 2012, 11:49 a.m. by Thomas Greiner
Modified:
Nov. 21, 2012, 4:36 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Renamed necessary components for ABP integration

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+748 lines, -823 lines) Patch
M .hgsubstate View 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/options.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/tests/tests/suffixTreeManipulation.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/content/typedItOptIn.xul View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
R chrome/locale/en-US/locale.dtd View 1 chunk +0 lines, -6 lines 0 comments Download
R chrome/locale/en-US/locale.properties View 1 chunk +0 lines, -3 lines 0 comments Download
A chrome/locale/en-US/typedItOptIn.dtd View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/locale/en-US/typo.properties View 1 chunk +3 lines, -0 lines 0 comments Download
R defaults/rules.json View 1 chunk +0 lines, -20 lines 0 comments Download
A defaults/typoRules.json View 1 chunk +20 lines, -0 lines 0 comments Download
R lib/appIntegration.js View 1 chunk +0 lines, -297 lines 0 comments Download
R lib/hooks.js View 1 chunk +0 lines, -75 lines 0 comments Download
R lib/rules.js View 1 chunk +0 lines, -409 lines 0 comments Download
M lib/survey.js View 1 chunk +1 line, -1 line 0 comments Download
A lib/typoAppIntegration.js View 1 chunk +297 lines, -0 lines 0 comments Download
M lib/typoFixer.js View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
A lib/typoRules.js View 1 chunk +409 lines, -0 lines 0 comments Download
M updateRules.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
Thomas Greiner
Oct. 10, 2012, 11:49 a.m. (2012-10-10 11:49:56 UTC) #1
Wladimir Palant
Please revert the changes to netError.xhtml - this isn't something that should be in ABP, ...
Oct. 10, 2012, 12:22 p.m. (2012-10-10 12:22:42 UTC) #2
Thomas Greiner
Oct. 10, 2012, 1:08 p.m. (2012-10-10 13:08:25 UTC) #3
Thomas Greiner
Oct. 10, 2012, 1:14 p.m. (2012-10-10 13:14:14 UTC) #4
Wladimir Palant
http://codereview.adblockplus.org/8554013/diff/4001/chrome/content/typedItOptIn.xul File chrome/content/typedItOptIn.xul (right): http://codereview.adblockplus.org/8554013/diff/4001/chrome/content/typedItOptIn.xul#newcode9 chrome/content/typedItOptIn.xul:9: <!DOCTYPE overlay SYSTEM "chrome://url-fixer/locale/typo.dtd"> Looks like you forgot to ...
Oct. 10, 2012, 1:17 p.m. (2012-10-10 13:17:50 UTC) #5
Thomas Greiner
Oct. 10, 2012, 1:59 p.m. (2012-10-10 13:59:35 UTC) #6
Thomas Greiner
http://codereview.adblockplus.org/8554013/diff/4001/chrome/content/typoNetError.xhtml File chrome/content/typoNetError.xhtml (right): http://codereview.adblockplus.org/8554013/diff/4001/chrome/content/typoNetError.xhtml#newcode1 chrome/content/typoNetError.xhtml:1: <?xml version="1.0"?> On 2012/10/10 13:17:50, Wladimir Palant wrote: > ...
Oct. 10, 2012, 1:59 p.m. (2012-10-10 13:59:43 UTC) #7
Wladimir Palant
Oct. 10, 2012, 2:20 p.m. (2012-10-10 14:20:23 UTC) #8 
LGTM

Powered by Google App Engine
This is Rietveld