Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8630094: adblockplusopera: Remove domain whitelisting (Closed)

Created:
Oct. 22, 2012, 3:37 p.m. by Felix Dahlke
Modified:
Nov. 14, 2012, 7:12 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Whitelisting of whole domains isn't supported by Opera's urlfilter, so I've removed the whitelisting tab from the options.

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M options.html View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 3
Wladimir Palant
http://codereview.adblockplus.org/8630094/diff/1/options.html File options.html (right): http://codereview.adblockplus.org/8630094/diff/1/options.html#newcode184 options.html:184: </div> Won't this cause errors in the code attempting ...
Oct. 23, 2012, 5:25 a.m. (2012-10-23 05:25:19 UTC) #1
Felix Dahlke
Issues addressed. http://codereview.adblockplus.org/8630094/diff/1/options.html File options.html (right): http://codereview.adblockplus.org/8630094/diff/1/options.html#newcode184 options.html:184: </div> On 2012/10/23 05:25:19, Wladimir Palant wrote: ...
Oct. 23, 2012, 7:28 a.m. (2012-10-23 07:28:44 UTC) #2
Wladimir Palant
Oct. 23, 2012, 8:01 a.m. (2012-10-23 08:01:39 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld