Issue 8680033: Made sure to enable acceptable ads and to open the first-run page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8680033: Made sure to enable acceptable ads and to open the first-run page (Closed)

Created:
Oct. 25, 2012, 4:20 p.m. by Wladimir Palant

Modified:
Oct. 26, 2012, 11:21 a.m.

Reviewers:
Thomas Greiner

Visibility:
Public.

Description

Lots of code moving around - this was Chrome-only code, I replaced it by the logic from lib/ui.js in ABP/Firefox with a few minor changes. One chunk of code was moved to the Utils module where it resides in Firefox (no changes other than that).

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: Oct. 25, 2012, 4:24 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -68 lines)			Patch
	M	background.js	View		2 chunks	+83 lines, -66 lines	1 comment	Download
	M	lib/adblockplus_compat.js	View	1	3 chunks	+42 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Thomas Greiner

Oct. 26, 2012, 9:09 a.m. (2012-10-26 09:09:48 UTC) #2

LGTM

http://codereview.adblockplus.org/8680033/diff/3001/background.js
File background.js (right):

http://codereview.adblockplus.org/8680033/diff/3001/background.js#newcode287
background.js:287: // Add "acceptable ads" subscription for new users and users
updating from old ABP versions.
please remove the point at the end of the sentence

Expand All Messages | Collapse All Messages