Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8684066: Fixed "Hide placeholders of blocked elements" feature (Closed)

Created:
Oct. 26, 2012, 1:56 p.m. by Wladimir Palant
Modified:
Oct. 26, 2012, 11:19 p.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Send a message to the content script if an element was blocked, it can then try to remove the element

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -12 lines) Patch
M include.preload.js View 1 1 chunk +23 lines, -0 lines 0 comments Download
M webrequest.js View 2 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Oct. 26, 2012, 1:56 p.m. (2012-10-26 13:56:46 UTC) #1
Thomas Greiner
some minor loop-optimizations which are useful for websites with a lot of images on them ...
Oct. 26, 2012, 2:21 p.m. (2012-10-26 14:21:54 UTC) #2
Wladimir Palant
http://codereview.adblockplus.org/8684066/diff/1/include.preload.js File include.preload.js (right): http://codereview.adblockplus.org/8684066/diff/1/include.preload.js#newcode66 include.preload.js:66: remove.push(elements[i]); On 2012/10/26 14:21:54, Thomas Greiner wrote: > we ...
Oct. 26, 2012, 2:34 p.m. (2012-10-26 14:34:23 UTC) #3
Thomas Greiner
Oct. 26, 2012, 2:35 p.m. (2012-10-26 14:35:59 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld