Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8689057: adblockpluschrome: Fix popup origin check when running on adblockplus.org (Closed)

Created:
Oct. 26, 2012, 9:39 a.m. by Felix Dahlke
Modified:
Oct. 26, 2012, 12:11 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M firstRun.js View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3
Wladimir Palant
http://codereview.adblockplus.org/8689057/diff/1/firstRun.js File firstRun.js (right): http://codereview.adblockplus.org/8689057/diff/1/firstRun.js#newcode19 firstRun.js:19: if (event.origin !== extractBaseUrl(url)) How about new backgroundPage.URI(url).prePath?
Oct. 26, 2012, 10:45 a.m. (2012-10-26 10:45:48 UTC) #1
Felix Dahlke
Uploaded a new patch set with a solution that works with share.adblockplus.org.
Oct. 26, 2012, 11:51 a.m. (2012-10-26 11:51:16 UTC) #2
Wladimir Palant
Oct. 26, 2012, 12:05 p.m. (2012-10-26 12:05:59 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld