Issue 8837074: ABP/Android Post-update starter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8837074: ABP/Android Post-update starter (Closed)

Created:
Nov. 15, 2012, 11:20 a.m. by Andrey Novikov

Modified:
Nov. 27, 2012, 10:51 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

BootBroadcastReceiver was renamed to Starter, so diff does not show changes. But you can compare them visually - they are very small. UPD: updated an issue, see side-by-side view, now it works.

Patch Set 2 : ABP/Android Post-update starter #

Total comments: 2

Created: Nov. 15, 2012, 11:31 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -23 lines)			Patch
	M	AndroidManifest.xml	View		2 chunks	+8 lines, -3 lines	0 comments	Download
	M	src/org/adblockplus/android/Starter.java	View	1	1 chunk	+30 lines, -20 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Felix Dahlke

http://codereview.adblockplus.org/8837074/diff/2001/src/org/adblockplus/android/Starter.java File src/org/adblockplus/android/Starter.java (right): http://codereview.adblockplus.org/8837074/diff/2001/src/org/adblockplus/android/Starter.java#newcode17 src/org/adblockplus/android/Starter.java:17: if (Intent.ACTION_PACKAGE_REPLACED.equals(intent.getAction())) intent.getAction() is used twice, I'd assign it ...

Nov. 16, 2012, 1:54 p.m. (2012-11-16 13:54:18 UTC) #3

Andrey Novikov

Nov. 16, 2012, 1:56 p.m. (2012-11-16 13:56:07 UTC) #4

Felix Dahlke

Nov. 16, 2012, 1:56 p.m. (2012-11-16 13:56:34 UTC) #5

On 2012/11/16 13:56:07, Andrey Novikov wrote:
>
http://codereview.adblockplus.org/8837074/diff/2001/src/org/adblockplus/andro...
> File src/org/adblockplus/android/Starter.java (right):
> 
>
http://codereview.adblockplus.org/8837074/diff/2001/src/org/adblockplus/andro...
> src/org/adblockplus/android/Starter.java:17: if
> (Intent.ACTION_PACKAGE_REPLACED.equals(intent.getAction()))
> On 2012/11/16 13:54:18, Felix H. Dahlke wrote:
> > intent.getAction() is used twice, I'd assign it to a temp.
> 
> Yes, I wanted to, but forgot. :) Fixed.

LGTM then.

Expand All Messages | Collapse All Messages