Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8851049: ABP/Android Domain specific filters (Closed)

Created:
Nov. 15, 2012, 7:38 a.m. by Andrey Novikov
Modified:
Nov. 27, 2012, 10:52 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Please disregard bools.xml

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M assets/js/start.js View 1 chunk +5 lines, -2 lines 0 comments Download
M res/values/bools.xml View 1 chunk +1 line, -1 line 1 comment Download
M src/org/adblockplus/brazil/RequestHandler.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2
Andrey Novikov
Nov. 15, 2012, 7:38 a.m. (2012-11-15 07:38:54 UTC) #1
Wladimir Palant
Nov. 15, 2012, 8 a.m. (2012-11-15 08:00:56 UTC) #2
LGTM assuming that the bools.xml change is unrelated and will not be part of
this patch.

http://codereview.adblockplus.org/8851049/diff/1/res/values/bools.xml
File res/values/bools.xml (right):

http://codereview.adblockplus.org/8851049/diff/1/res/values/bools.xml#newcode6
res/values/bools.xml:6: <bool name="def_release">false</bool>
Is that change intended?

Powered by Google App Engine
This is Rietveld