Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8943041: ABP/Android Notification not showing fix (Closed)

Created:
Nov. 23, 2012, 1:13 p.m. by Andrey Novikov
Modified:
Nov. 30, 2012, 9:45 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

ABP/Android Notification not showing fix

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -14 lines) Patch
M src/org/adblockplus/android/Preferences.java View 9 chunks +34 lines, -13 lines 4 comments Download
M src/org/adblockplus/android/ProxyService.java View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 4
Andrey Novikov
Nov. 23, 2012, 1:13 p.m. (2012-11-23 13:13:06 UTC) #1
Felix Dahlke
Just two nits. http://codereview.adblockplus.org/8943041/diff/1/src/org/adblockplus/android/Preferences.java File src/org/adblockplus/android/Preferences.java (right): http://codereview.adblockplus.org/8943041/diff/1/src/org/adblockplus/android/Preferences.java#newcode410 src/org/adblockplus/android/Preferences.java:410: if (! trafficDetected) Preferably no space ...
Nov. 23, 2012, 1:19 p.m. (2012-11-23 13:19:43 UTC) #2
Andrey Novikov
http://codereview.adblockplus.org/8943041/diff/1/src/org/adblockplus/android/Preferences.java File src/org/adblockplus/android/Preferences.java (right): http://codereview.adblockplus.org/8943041/diff/1/src/org/adblockplus/android/Preferences.java#newcode410 src/org/adblockplus/android/Preferences.java:410: if (! trafficDetected) On 2012/11/23 13:19:43, Felix H. Dahlke ...
Nov. 30, 2012, 9:43 a.m. (2012-11-30 09:43:38 UTC) #3
Felix Dahlke
Nov. 30, 2012, 9:44 a.m. (2012-11-30 09:44:41 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld