Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8951121: adblockplusandroid: Use Holo theme in Android 3.0 and above (Closed)

Created:
Dec. 1, 2012, 8:27 a.m. by Felix Dahlke
Modified:
Jan. 2, 2013, 8:28 a.m.
Reviewers:
Andrey Novikov
Visibility:
Public.

Description

This is an experimental change that allows us to use the modern Holo theme on Android 3.0 and above. Here are some screenshots: https://docs.google.com/open?id=0B0zm9ipEYmdqUlVzY2JCUWZfUEk https://docs.google.com/open?id=0B0zm9ipEYmdqSHZtVlhzS1VTQVk I had to set the build target to 11 for this to compile, so you'll have to get the Android 3.0 SDK. We can also use any later SDK. I've tested it in simulators running Android 2.1, 2.3 and 4.1. The changes are in the holo-theme branch.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M AndroidManifest.xml View 1 chunk +2 lines, -1 line 0 comments Download
M project.properties View 1 chunk +1 line, -1 line 0 comments Download
A res/values-v11/styles.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Felix Dahlke
Dec. 1, 2012, 8:30 a.m. (2012-12-01 08:30:49 UTC) #1
Felix Dahlke
Jan. 2, 2013, 8:28 a.m. (2013-01-02 08:28:42 UTC) #2
Closing this issue since Andrey carries on with this.

Powered by Google App Engine
This is Rietveld