Issue 8956033: android: fixed crash on calling callback

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8956033: android: fixed crash on calling callback (Closed)

Created:
Nov. 27, 2012, 1:54 p.m. by Andrey Novikov

Modified:
Nov. 28, 2012, 8:09 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

android: fixed crash on calling callback

Patch Set 1 #

Created: Nov. 27, 2012, 1:54 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/org/adblockplus/android/AdblockPlus.java	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Felix Dahlke

On 2012/11/27 13:54:43, Andrey Novikov wrote: LGTM

Nov. 28, 2012, 8:06 a.m. (2012-11-28 08:06:22 UTC) #2

Felix Dahlke

Nov. 28, 2012, 8:09 a.m. (2012-11-28 08:09:44 UTC) #3

On 2012/11/28 08:06:22, Felix H. Dahlke wrote:
> On 2012/11/27 13:54:43, Andrey Novikov wrote:
> 
> LGTM

Actually, after a second look, I think it makes sense to move the check up to
the first line:

if (result != null && js != null)
...

Also, is that the only place were js can suddenly be null? If not, it maybe
worth handling in a central place.

Expand All Messages | Collapse All Messages