android: notification icon option

src/org/adblockplus/android/AdvancedPreferences.java

 /*
  * This file is part of the Adblock Plus,
  * Copyright (C) 2006-2012 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 34 matching lines @@
 import android.widget.Toast;
 
 /**
  * Advanced settings UI.
  */
 public class AdvancedPreferences extends SummarizedPreferences
 {
   private static final String TAG = "AdvancedPreferences";
 
   private static final int CONFIGURATION_DIALOG = 1;
+  private static final int PRIORITY_WARNING_DIALOG = 2;
 
   private static ProxyService proxyService = null;
 
   @Override
   public void onCreate(Bundle savedInstanceState)
   {
     super.onCreate(savedInstanceState);
 
     addPreferencesFromResource(R.xml.preferences_advanced);
 
@@ skipping 44 matching lines @@
   @Override
   public void onPause()
   {
     super.onPause();
     disconnect();
   }
 
   @Override
   public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String key)
   {
+    if (getString(R.string.pref_priority).equals(key))
+    {
+      if (!sharedPreferences.getBoolean(key, false))
+        showDialog(PRIORITY_WARNING_DIALOG);
+    }
     if (getString(R.string.pref_refresh).equals(key))
     {
       int refresh = Integer.valueOf(sharedPreferences.getString(key, "0"));
       findPreference(getString(R.string.pref_wifirefresh)).setEnabled(refresh > 0);
     }
     if (getString(R.string.pref_crashreport).equals(key))
     {
       boolean report = sharedPreferences.getBoolean(key, getResources().getBoolean(R.bool.def_crashreport));
       try
       {
         CrashHandler handler = (CrashHandler) Thread.getDefaultUncaughtExceptionHandler();
         handler.generateReport(report);
       }
       catch (ClassCastException e)
       {
         // ignore - default handler in use
       }
     }
     super.onSharedPreferenceChanged(sharedPreferences, key);
   }
 
   @Override
   protected Dialog onCreateDialog(int id)
   {
     Dialog dialog = null;
+    AlertDialog.Builder builder = new AlertDialog.Builder(this);
+
     switch (id)
     {
+      case PRIORITY_WARNING_DIALOG:
+        // @formatter:off

[Felix Dahlke, 2012/11/28 09:47:35]

Why do this? You can set up Eclipse do indent that way, and we can share the
formatter configuration.

[Andrey Novikov, 2012/11/28 09:53:33]

Really? How do I achieve that?

+        builder.setTitle(R.string.warning)
+               .setIcon(android.R.drawable.ic_dialog_alert)
+               .setMessage(R.string.msg_priority_warning)
+               .setCancelable(false)
+               .setPositiveButton(R.string.gotit, new DialogInterface.OnClickListener()
+                {
+                  public void onClick(DialogInterface dialog, int id)
+                  {
+                    dialog.cancel();
+                  }
+                });
+        // @formatter:on
+        dialog = builder.create();
+        break;
       case CONFIGURATION_DIALOG:
         List<String> items = new ArrayList<String>();
         items.add(AdblockPlus.getDeviceName());
         items.add(String.format("API: %d Build: %d", Build.VERSION.SDK_INT, AdblockPlus.getApplication().getBuildNumber()));
         if (proxyService != null)
         {
           items.add(String.format("Local port: %d", proxyService.port));
           if (proxyService.isTransparent())
           {
             items.add("Running in root mode");
@@ skipping 43 matching lines @@
           public void onClick(View v)
           {
             ClipboardManager manager = (ClipboardManager) getSystemService(CLIPBOARD_SERVICE);
             TextView showTextParam = (TextView) v;
             manager.setText(showTextParam.getText());
             Toast.makeText(v.getContext(), R.string.msg_clipboard, Toast.LENGTH_SHORT).show();
           }
         });
         scrollPane.addView(messageText);
 
-        AlertDialog.Builder builder = new AlertDialog.Builder(this);
-        builder.setView(scrollPane).setTitle(R.string.configuration_name).setIcon(android.R.drawable.ic_dialog_info).setCancelable(false)
-            .setPositiveButton(R.string.ok, new DialogInterface.OnClickListener()
-            {
-              public void onClick(DialogInterface dialog, int id)
-              {
-                dialog.cancel();
-              }
-            });
+        // @formatter:off

[Felix Dahlke, 2012/11/28 09:47:35]

See above, I think we should configure the formatter properly instead.

+        builder.setView(scrollPane)
+               .setTitle(R.string.configuration_name)
+               .setIcon(android.R.drawable.ic_dialog_info)
+               .setCancelable(false)
+               .setPositiveButton(R.string.ok, new DialogInterface.OnClickListener()
+                {
+                  public void onClick(DialogInterface dialog, int id)
+                  {
+                    dialog.cancel();
+                  }
+                });
+        // @formatter:on
         dialog = builder.create();
         break;
     }
     return dialog;
   }
 
   private void connect()
   {
     bindService(new Intent(this, ProxyService.class), proxyServiceConnection, 0);
   }
@@ skipping 12 matching lines @@
       Log.d(TAG, "Proxy service connected");
     }
 
     public void onServiceDisconnected(ComponentName className)
     {
       proxyService = null;
       Log.d(TAG, "Proxy service disconnected");
     }
   };
 }