Issue 8959056: android: notification icon option

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8959056: android: notification icon option (Closed)

Created:
Nov. 28, 2012, 8:19 a.m. by Andrey Novikov

Modified:
Dec. 3, 2012, 9:24 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: Nov. 28, 2012, 8:19 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -11 lines)			Patch
M	res/values/bools.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	res/values/strings.xml	View	3 chunks	+5 lines, -0 lines	0 comments	Download
M	res/values/sysstrings.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	res/xml/preferences_advanced.xml	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/org/adblockplus/android/AdvancedPreferences.java	View	4 chunks	+37 lines, -9 lines	3 comments	Download
M	src/org/adblockplus/android/ProxyService.java	View	5 chunks	+31 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Felix Dahlke

Like I said in IRC, I think we should make the option much more visible. ...

Nov. 28, 2012, 9:47 a.m. (2012-11-28 09:47:35 UTC) #2

Andrey Novikov

http://codereview.adblockplus.org/8959056/diff/1/src/org/adblockplus/android/AdvancedPreferences.java File src/org/adblockplus/android/AdvancedPreferences.java (right): http://codereview.adblockplus.org/8959056/diff/1/src/org/adblockplus/android/AdvancedPreferences.java#newcode155 src/org/adblockplus/android/AdvancedPreferences.java:155: // @formatter:off On 2012/11/28 09:47:35, Felix H. Dahlke wrote: ...

Nov. 28, 2012, 9:53 a.m. (2012-11-28 09:53:33 UTC) #3

Felix Dahlke

Nov. 28, 2012, 10:07 a.m. (2012-11-28 10:07:09 UTC) #4

On 2012/11/28 09:53:33, Andrey Novikov wrote:
>
http://codereview.adblockplus.org/8959056/diff/1/src/org/adblockplus/android/...
> File src/org/adblockplus/android/AdvancedPreferences.java (right):
> 
>
http://codereview.adblockplus.org/8959056/diff/1/src/org/adblockplus/android/...
> src/org/adblockplus/android/AdvancedPreferences.java:155: // @formatter:off
> On 2012/11/28 09:47:35, Felix H. Dahlke wrote:
> > Why do this? You can set up Eclipse do indent that way, and we can share the
> > formatter configuration.
> 
> Really? How do I achieve that?

Not sure if we can get it JUST how you'd like it, but close:

You can configure the Formatter in the preferences, under Java->Code
Style->Formatter and then Edit.

Under Line Wrapping->Qualified Invocations, you can set it to indent one level,
two levels or on column.

Expand All Messages | Collapse All Messages