Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8960162: android: notification icon option (Closed)

Created:
Dec. 4, 2012, 6:37 a.m. by Andrey Novikov
Modified:
Dec. 4, 2012, 10:50 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

android: notification icon option

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -28 lines) Patch
A res/drawable/transparent.png View Binary file 0 comments Download
M res/values/bools.xml View 1 chunk +1 line, -0 lines 0 comments Download
M res/values/strings.xml View 3 chunks +5 lines, -0 lines 2 comments Download
M res/values/sysstrings.xml View 1 chunk +1 line, -0 lines 0 comments Download
M res/xml/preferences.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M src/org/adblockplus/android/Preferences.java View 8 chunks +39 lines, -25 lines 0 comments Download
M src/org/adblockplus/android/ProxyService.java View 4 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 3
Andrey Novikov
Dec. 4, 2012, 6:37 a.m. (2012-12-04 06:37:31 UTC) #1
Wladimir Palant
LGTM http://codereview.adblockplus.org/8960162/diff/1/res/values/strings.xml File res/values/strings.xml (right): http://codereview.adblockplus.org/8960162/diff/1/res/values/strings.xml#newcode28 res/values/strings.xml:28: <string name="msg_hideicon_warning">Please note that we cannot completely remove ...
Dec. 4, 2012, 9:08 a.m. (2012-12-04 09:08:53 UTC) #2
Andrey Novikov
Dec. 4, 2012, 9:23 a.m. (2012-12-04 09:23:52 UTC) #3
http://codereview.adblockplus.org/8960162/diff/1/res/values/strings.xml
File res/values/strings.xml (right):

http://codereview.adblockplus.org/8960162/diff/1/res/values/strings.xml#newco...
res/values/strings.xml:28: <string name="msg_hideicon_warning">Please note that
we cannot completely remove the icon, only make it invisible. Without the icon
Android might stop Adblock Plus any time which will result in connectivity
loss.</string>
On 2012/12/04 09:08:53, Wladimir Palant wrote:
> "result in loss of connectivity" is better apparently.

Done.

Powered by Google App Engine
This is Rietveld