Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 8961061: android: fixed crash (Closed)

Created:
Nov. 28, 2012, 6:39 a.m. by Andrey Novikov
Modified:
Feb. 22, 2013, 8:35 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

android: fixed crash

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/org/adblockplus/android/ProxyService.java View 1 chunk +2 lines, -1 line 3 comments Download

Messages

Total messages: 4
Andrey Novikov
Nov. 28, 2012, 6:40 a.m. (2012-11-28 06:40:03 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/8961061/diff/1/src/org/adblockplus/android/ProxyService.java File src/org/adblockplus/android/ProxyService.java (right): http://codereview.adblockplus.org/8961061/diff/1/src/org/adblockplus/android/ProxyService.java#newcode315 src/org/adblockplus/android/ProxyService.java:315: if (proxy != null) When can the proxy be ...
Nov. 28, 2012, 8:35 a.m. (2012-11-28 08:35:37 UTC) #2
Andrey Novikov
http://codereview.adblockplus.org/8961061/diff/1/src/org/adblockplus/android/ProxyService.java File src/org/adblockplus/android/ProxyService.java (right): http://codereview.adblockplus.org/8961061/diff/1/src/org/adblockplus/android/ProxyService.java#newcode315 src/org/adblockplus/android/ProxyService.java:315: if (proxy != null) On 2012/11/28 08:35:38, Felix H. ...
Feb. 22, 2013, 8:31 a.m. (2013-02-22 08:31:32 UTC) #3
Felix Dahlke
Feb. 22, 2013, 8:35 a.m. (2013-02-22 08:35:03 UTC) #4
LGTM

http://codereview.adblockplus.org/8961061/diff/1/src/org/adblockplus/android/...
File src/org/adblockplus/android/ProxyService.java (right):

http://codereview.adblockplus.org/8961061/diff/1/src/org/adblockplus/android/...
src/org/adblockplus/android/ProxyService.java:315: if (proxy != null)
On 2013/02/22 08:31:32, Andrey Novikov wrote:
> Not only on exception. I do not know why but it's commont in Android world
when
> onClose/onDestroy is called without onOpen/onCreate being called. It's weird
but
> I often got NullPointerException's in logs before I started to add such checks
> in finalizers.

So onDestroy is sometimes called without onCreate being called first? Not
satisfactory, but not something we should comment here if we need to do it in
every activity...

Powered by Google App Engine
This is Rietveld