Issue 8961061: android: fixed crash

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8961061: android: fixed crash (Closed)

Created:
Nov. 28, 2012, 6:39 a.m. by Andrey Novikov

Modified:
Feb. 22, 2013, 8:35 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: Nov. 28, 2012, 6:39 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/org/adblockplus/android/ProxyService.java	View		1 chunk	+2 lines, -1 line	3 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Felix Dahlke

http://codereview.adblockplus.org/8961061/diff/1/src/org/adblockplus/android/ProxyService.java File src/org/adblockplus/android/ProxyService.java (right): http://codereview.adblockplus.org/8961061/diff/1/src/org/adblockplus/android/ProxyService.java#newcode315 src/org/adblockplus/android/ProxyService.java:315: if (proxy != null) When can the proxy be ...

Nov. 28, 2012, 8:35 a.m. (2012-11-28 08:35:37 UTC) #2

Andrey Novikov

Feb. 22, 2013, 8:31 a.m. (2013-02-22 08:31:32 UTC) #3

Felix Dahlke

Feb. 22, 2013, 8:35 a.m. (2013-02-22 08:35:03 UTC) #4

LGTM

http://codereview.adblockplus.org/8961061/diff/1/src/org/adblockplus/android/...
File src/org/adblockplus/android/ProxyService.java (right):

http://codereview.adblockplus.org/8961061/diff/1/src/org/adblockplus/android/...
src/org/adblockplus/android/ProxyService.java:315: if (proxy != null)
On 2013/02/22 08:31:32, Andrey Novikov wrote:
> Not only on exception. I do not know why but it's commont in Android world
when
> onClose/onDestroy is called without onOpen/onCreate being called. It's weird
but
> I often got NullPointerException's in logs before I started to add such checks
> in finalizers.

So onDestroy is sometimes called without onCreate being called first? Not
satisfactory, but not something we should comment here if we need to do it in
every activity...

Expand All Messages | Collapse All Messages