Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9001046: Fixed wrongly rejected RSA signatures (Closed)

Created:
Dec. 11, 2012, 4:36 p.m. by Wladimir Palant
Modified:
Dec. 12, 2012, 12:41 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Fixed wrongly rejected RSA signatures

Patch Set 1 #

Patch Set 2 : More robust approach #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -175 lines) Patch
M lib/rsa.js View 1 1 chunk +177 lines, -175 lines 0 comments Download
M qunit/tests/signatures.js View 1 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Dec. 11, 2012, 4:36 p.m. (2012-12-11 16:36:05 UTC) #1
Felix Dahlke
LGTM
Dec. 12, 2012, 12:06 p.m. (2012-12-12 12:06:47 UTC) #2
Wladimir Palant
Dec. 12, 2012, 12:29 p.m. (2012-12-12 12:29:29 UTC) #3
Felix Dahlke
Dec. 12, 2012, 12:37 p.m. (2012-12-12 12:37:17 UTC) #4
Even more LGTM :)

Powered by Google App Engine
This is Rietveld