Issue 9044122: Fixed regression: menu selection doesn't work on mobile

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9044122: Fixed regression: menu selection doesn't work on mobile (Closed)

Created:
Dec. 21, 2012, 11:16 a.m. by Thomas Greiner

Modified:
Dec. 21, 2012, 1:45 p.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

Fixed regression: menu selection doesn't work on mobile

Patch Set 1 #

Total comments: 1

Created: Dec. 21, 2012, 11:16 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	anwiki/_override-static/global/global/js/main.js	View		1 chunk	+8 lines, -5 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Felix Dahlke

http://codereview.adblockplus.org/9044122/diff/1/anwiki/_override-static/global/global/js/main.js File anwiki/_override-static/global/global/js/main.js (right): http://codereview.adblockplus.org/9044122/diff/1/anwiki/_override-static/global/global/js/main.js#newcode80 anwiki/_override-static/global/global/js/main.js:80: if ("querySelector" in document) Why not just: if (document.querySelector)

Dec. 21, 2012, 12:57 p.m. (2012-12-21 12:57:12 UTC) #2

Thomas Greiner

On 2012/12/21 12:57:12, Felix H. Dahlke wrote: > http://codereview.adblockplus.org/9044122/diff/1/anwiki/_override-static/global/global/js/main.js > File anwiki/_override-static/global/global/js/main.js (right): > > ...

Dec. 21, 2012, 1:29 p.m. (2012-12-21 13:29:54 UTC) #3

Felix Dahlke

Dec. 21, 2012, 1:31 p.m. (2012-12-21 13:31:18 UTC) #4

On 2012/12/21 13:29:54, Thomas Greiner wrote:
> On 2012/12/21 12:57:12, Felix H. Dahlke wrote:
> >
>
http://codereview.adblockplus.org/9044122/diff/1/anwiki/_override-static/glob...
> > File anwiki/_override-static/global/global/js/main.js (right):
> > 
> >
>
http://codereview.adblockplus.org/9044122/diff/1/anwiki/_override-static/glob...
> > anwiki/_override-static/global/global/js/main.js:80: if ("querySelector" in
> > document)
> > Why not just:
> > 
> > if (document.querySelector)
> 
> I usually do it like that but it would be inconsistent with how we do it in
> other projects.

I always prefer non-strings to strings, easier for tools to analyse. I know,
we're not using any linters or refactoring thingies right now, but I still think
it's more robust :)

Anyway, LGTM apart from that.

Expand All Messages | Collapse All Messages