Changes to Chrome build process

Four changes here: introducing build.py devenv command (creates a test directory), changing the approach for Chrome from a files blacklist to a whitelist, generating manifest.json dynamically from metadata and converting files from ABP/Firefox during build

[Wladimir Palant, 2012-12-20 14:25:25]

Updated the patches to fix issues running jshydra when both regular and
experimental nightlies are created. jshydra is part of the extension repository,
not buildtools. This means that we work with two different jshydra instances
when creating builds.

The solution I implemented now is rather hacky. A better solution would be
making jshydra a subrepository of buildtools rather than adblockpluschrome.
Sitescripts use their own buildtools copy when creating nightlies, consequently
there would be only one jshydra instance. That would however mean that all our
extensions would suddenly become dependent on jshydra, even the Firefox ones -
not sure whether this is really preferable.

[Wladimir Palant, 2012-12-29 20:17:28]

I moved JSHydra dependency to build tools after all, it made the code simpler
and less error-prone. Also, now the devenv will poll to detect its changes and
try to reload itself (semi-working, e.g. global data like manifest or locale
strings don't reload).

[Felix Dahlke, 2013-01-11 12:24:16]

LGTM except for that nit. But it appears that you'll have to grant SSH access to
jshydra for everyone who's got SSH access to buildtools and adblockpluschrome.

http://codereview.adblockplus.org/9051052/diff/8001/packagerChrome.py
File packagerChrome.py (right):

http://codereview.adblockplus.org/9051052/diff/8001/packagerChrome.py#newcode82
packagerChrome.py:82: size = file[len(prefix):-len(suffix)]
How about using a regex here?

if os.path.isfile(path):
  match = re.match(prefix + r'(.*)' + suffix, file)
  if match:
    size = match.group(0)

It's a bit longer vertically, but I bet easier to maintain. Your call.

[Wladimir Palant, 2013-01-11 14:45:39]

Yes, everybody will need access to all the subrepositories unfortunately - even
if they don't change anything there. I would like to have "read-only" subrepos
but it doesn't look like Mercurial allows that...

http://codereview.adblockplus.org/9051052/diff/8001/packagerChrome.py
File packagerChrome.py (right):

http://codereview.adblockplus.org/9051052/diff/8001/packagerChrome.py#newcode82
packagerChrome.py:82: size = file[len(prefix):-len(suffix)]
On 2013/01/11 12:24:16, Felix H. Dahlke wrote:
> How about using a regex here?

As soon as we add the required escaping (prefix and suffix can be anything,
could include special characters like e.g. ".") and the missing ^ and $ things
won't be simple at all any more. No, regexps are a pretty bad choice if you need
to do string comparison.

[Felix Dahlke, 2013-01-11 14:47:55]

LGTM

http://codereview.adblockplus.org/9051052/diff/8001/packagerChrome.py
File packagerChrome.py (right):

http://codereview.adblockplus.org/9051052/diff/8001/packagerChrome.py#newcode82
packagerChrome.py:82: size = file[len(prefix):-len(suffix)]
On 2013/01/11 14:45:39, Wladimir Palant wrote:
> On 2013/01/11 12:24:16, Felix H. Dahlke wrote:
> > How about using a regex here?
> 
> As soon as we add the required escaping (prefix and suffix can be anything,
> could include special characters like e.g. ".") and the missing ^ and $ things
> won't be simple at all any more. No, regexps are a pretty bad choice if you
need
> to do string comparison.

Right, forgot about the escaping. I suppose it's better this way.