Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9051084: Changed images to use CSS sprites (Closed)

Created:
Dec. 20, 2012, 3:54 p.m. by Thomas Greiner
Modified:
Dec. 21, 2012, 10:41 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Changed images to use CSS sprites and fixed regression issues.

Patch Set 1 #

Patch Set 2 : Removed trailing whitespaces #

Total comments: 4

Patch Set 3 : Removed regression fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -28 lines) Patch
M anwiki/_override-static/global/global/css/features.css View 3 chunks +69 lines, -2 lines 0 comments Download
M anwiki/_override-static/global/global/css/features-mobile.css View 1 chunk +1 line, -1 line 0 comments Download
M anwiki/_override-static/global/global/css/index.css View 5 chunks +64 lines, -3 lines 0 comments Download
M anwiki/_override-static/global/global/css/main.css View 4 chunks +119 lines, -6 lines 0 comments Download
M anwiki/_override-static/global/global/css/main-desktop.css View 1 3 chunks +4 lines, -3 lines 0 comments Download
M anwiki/_override-static/global/global/css/main-mobile.css View 1 2 3 chunks +17 lines, -6 lines 0 comments Download
A anwiki/_override-static/global/global/img/sprite-features.png View Binary file 0 comments Download
A anwiki/_override-static/global/global/img/sprite-flags.png View Binary file 0 comments Download
A anwiki/_override-static/global/global/img/sprite-index.png View Binary file 0 comments Download
A anwiki/_override-static/global/global/img/sprite-main.png View Binary file 0 comments Download
A anwiki/_override-static/global/global/js/vendor/DD_belatedPNG.js View 1 chunk +13 lines, -0 lines 0 comments Download
M anwiki/_override/actions/action_view/action_view.tpl.php View 2 chunks +4 lines, -4 lines 0 comments Download
M anwiki/_override/global/global/global.tpl.php View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Thomas Greiner
Removing #menu broke the menu selection on mobile. Hope you don't mind that I included ...
Dec. 20, 2012, 4:03 p.m. (2012-12-20 16:03:10 UTC) #1
Felix Dahlke
Some smallish issues. http://codereview.adblockplus.org/9051084/diff/5001/anwiki/_override-static/global/global/css/index-mobile.css File anwiki/_override-static/global/global/css/index-mobile.css (right): http://codereview.adblockplus.org/9051084/diff/5001/anwiki/_override-static/global/global/css/index-mobile.css#newcode8 anwiki/_override-static/global/global/css/index-mobile.css:8: #content>div:first-child I've removed this deliberately, because ...
Dec. 21, 2012, 9:20 a.m. (2012-12-21 09:20:11 UTC) #2
Thomas Greiner
Removed regression fix http://codereview.adblockplus.org/9051084/diff/5001/anwiki/_override/contentclasses/contentclass_menu/contentclass_menu.tpl.php File anwiki/_override/contentclasses/contentclass_menu/contentclass_menu.tpl.php (right): http://codereview.adblockplus.org/9051084/diff/5001/anwiki/_override/contentclasses/contentclass_menu/contentclass_menu.tpl.php#newcode11 anwiki/_override/contentclasses/contentclass_menu/contentclass_menu.tpl.php:11: <ul id="menu"> On 2012/12/21 09:20:11, Felix ...
Dec. 21, 2012, 9:48 a.m. (2012-12-21 09:48:48 UTC) #3
Felix Dahlke
Dec. 21, 2012, 10:23 a.m. (2012-12-21 10:23:00 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld