Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9158140: Packager refactoring, moved common packager code into separate module (Closed)

Created:
Jan. 10, 2013, 7:57 p.m. by Wladimir Palant
Modified:
Jan. 16, 2013, 2:39 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

There were two somewhat related changes (https://hg.adblockplus.org/buildtools/rev/b31dca40b100 and https://hg.adblockplus.org/sitescripts/rev/c4b250d26aee), not sure whether you want reviews for those as well

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -74 lines) Patch
A packager.py View 1 chunk +67 lines, -0 lines 0 comments Download
M packagerChrome.py View 3 chunks +8 lines, -39 lines 0 comments Download
M packagerGecko.py View 5 chunks +8 lines, -35 lines 0 comments Download

Messages

Total messages: 2
Wladimir Palant
Jan. 10, 2013, 7:57 p.m. (2013-01-10 19:57:41 UTC) #1
Felix Dahlke
Jan. 11, 2013, 3:52 p.m. (2013-01-11 15:52:01 UTC) #2
LGTM (this and the related changes)

Powered by Google App Engine
This is Rietveld