Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9241058: Bug 819131 work-around, use user data instead of weak maps (Closed)

Created:
Jan. 23, 2013, 10:13 a.m. by Wladimir Palant
Modified:
Jan. 23, 2013, 3:14 p.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Bug 819131 work-around, use user data instead of weak maps

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M lib/requestNotifier.js View 1 1 chunk +5 lines, -4 lines 1 comment Download

Messages

Total messages: 4
Wladimir Palant
Jan. 23, 2013, 10:13 a.m. (2013-01-23 10:13:26 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/9241058/diff/1/lib/requestNotifier.js File lib/requestNotifier.js (right): http://codereview.adblockplus.org/9241058/diff/1/lib/requestNotifier.js#newcode34 lib/requestNotifier.js:34: // Bug 673468 and bug 819131 are fixed, we ...
Jan. 23, 2013, 2:15 p.m. (2013-01-23 14:15:28 UTC) #2
Wladimir Palant
I've improved the comment. http://codereview.adblockplus.org/9241058/diff/6001/lib/requestNotifier.js File lib/requestNotifier.js (right): http://codereview.adblockplus.org/9241058/diff/6001/lib/requestNotifier.js#newcode47 lib/requestNotifier.js:47: let getProp = function(map) Please ...
Jan. 23, 2013, 2:48 p.m. (2013-01-23 14:48:33 UTC) #3
Felix Dahlke
Jan. 23, 2013, 3:01 p.m. (2013-01-23 15:01:34 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld