Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9251039: Get rid of nested functions declarations that are not on top level (causes strict mode warnings) (Closed)

Created:
Jan. 23, 2013, 12:52 p.m. by Wladimir Palant
Modified:
Feb. 6, 2013, 8:46 a.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Some of the changes will need to be backported to URL Fixer.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -68 lines) Patch
M chrome/content/errors.html View 2 chunks +9 lines, -8 lines 0 comments Download
M lib/appSupport.js View 4 chunks +4 lines, -4 lines 0 comments Download
M lib/io.js View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/objectTabs.js View 2 chunks +34 lines, -34 lines 0 comments Download
M lib/requestNotifier.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/synchronizer.js View 3 chunks +6 lines, -6 lines 0 comments Download
M lib/typoAppIntegration.js View 4 chunks +10 lines, -10 lines 0 comments Download
M lib/ui.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
Jan. 23, 2013, 12:52 p.m. (2013-01-23 12:52:38 UTC) #1
Thomas Greiner
LGTM, but you seem to have pushed the changes anyway ;)
Jan. 24, 2013, 12:53 p.m. (2013-01-24 12:53:29 UTC) #2
Wladimir Palant
Jan. 24, 2013, 3:35 p.m. (2013-01-24 15:35:27 UTC) #3
On 2013/01/24 12:53:29, Thomas Greiner wrote:
> LGTM, but you seem to have pushed the changes anyway ;)

Yes, I wanted to start testing of these changes already so that we can release
on Tuesday.

Powered by Google App Engine
This is Rietveld