Issue 9257092: More build tools improvements

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9257092: More build tools improvements (Closed)

Created:
Jan. 25, 2013, 10:22 a.m. by Wladimir Palant

Modified:
April 25, 2014, 11:01 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

Three changes here: fixed type error when build number is specified from the command line, made locale imports from Firefox to Chrome happen during build rather than manually and fixed handling of relative paths in manifests for some options (important if a manifest inherits from another in a different directory).

Patch Set 1 #

Patch Set 2 : Added some more changes required to build Firefox and Chrome extensions from the same repository (s… #

Created: Jan. 25, 2013, 1:47 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -177 lines)			Patch
M	build.py	View		2 chunks	+0 lines, -16 lines	0 comments	Download
M	chainedconfigparser.py	View		3 chunks	+18 lines, -2 lines	0 comments	Download
R	localeSyncChrome.py	View		1 chunk	+0 lines, -135 lines	0 comments	Download
M	localeTools.py	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	manifest.json.tmpl	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	packager.py	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	packagerChrome.py	View	1	4 chunks	+113 lines, -6 lines	0 comments	Download
M	packagerGecko.py	View		2 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

Added some more changes required to build Firefox and Chrome extensions from the same repository ...

Jan. 25, 2013, 1:47 p.m. (2013-01-25 13:47:48 UTC) #2

Felix Dahlke

April 25, 2014, 10:39 a.m. (2014-04-25 10:39:20 UTC) #3

LGTM

Note that this is a bit ancient, so I just did a pretty high-level review to
roughly figure out what's going on.

Expand All Messages | Collapse All Messages