Issue 9271056: ABP/Android V8 integration code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9271056: ABP/Android V8 integration code (Closed)

Created:
Jan. 30, 2013, 9:27 a.m. by Andrey Novikov

Modified:
Feb. 22, 2013, 8:32 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

Take into account that I am not good in C, didn't use it for more then 10 years.

Patch Set 1 #

Patch Set 2 : ABP/Android V8 integration code #

Created: Feb. 1, 2013, 8:40 a.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1240 lines, -0 lines)			Patch
A	jni/Android.mk	View		1 chunk	+48 lines, -0 lines	0 comments	Download
A	jni/Application.mk	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	jni/debug.h	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
A	jni/fileOps.cpp	View	1	1 chunk	+212 lines, -0 lines	0 comments	Download
A	jni/jsEngine.cpp	View	1	1 chunk	+280 lines, -0 lines	0 comments	Download
A	jni/ops.h	View	1	1 chunk	+41 lines, -0 lines	0 comments	Download
A	jni/timerOps.cpp	View	1	1 chunk	+100 lines, -0 lines	0 comments	Download
A	jni/utilityOps.cpp	View	1	1 chunk	+157 lines, -0 lines	0 comments	Download
A	jni/wrap.h	View		1 chunk	+24 lines, -0 lines	0 comments	Download
A	jni/wrap.cpp	View	1	1 chunk	+159 lines, -0 lines	0 comments	Download
A	jni/xhrOps.cpp	View	1	1 chunk	+93 lines, -0 lines	0 comments	Download
A	src/org/adblockplus/android/JSEngine.java	View		1 chunk	+105 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Felix Dahlke

Feb. 22, 2013, 8:15 a.m. (2013-02-22 08:15:50 UTC) #3

Assuming that we will be using libadblockplus (which is to some extent based on
this) in ABP for Android sooner or later, I think we can close this review.

Expand All Messages | Collapse All Messages