Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9316018: ABP/Android Holo theme (Closed)

Created:
Feb. 1, 2013, 7:55 a.m. by Andrey Novikov
Modified:
Feb. 6, 2013, 10:04 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

ABP/Android Holo theme

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -86 lines) Patch
M AndroidManifest.xml View 2 chunks +10 lines, -5 lines 2 comments Download
M project.properties View 1 chunk +2 lines, -1 line 2 comments Download
M res/layout/preferences.xml View 1 chunk +0 lines, -49 lines 0 comments Download
M res/menu/menu_preferences.xml View 1 chunk +12 lines, -0 lines 0 comments Download
M res/raw/legal.txt View 1 chunk +2 lines, -1 line 0 comments Download
M res/values/styles.xml View 1 chunk +4 lines, -3 lines 0 comments Download
M src/org/adblockplus/android/Preferences.java View 5 chunks +14 lines, -25 lines 0 comments Download
M src/org/adblockplus/android/SummarizedPreferences.java View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Andrey Novikov
Feb. 1, 2013, 7:56 a.m. (2013-02-01 07:56:59 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/9316018/diff/1/AndroidManifest.xml File AndroidManifest.xml (right): http://codereview.adblockplus.org/9316018/diff/1/AndroidManifest.xml#newcode21 AndroidManifest.xml:21: android:allowBackup="true" How I understand it, we should set this ...
Feb. 1, 2013, 12:11 p.m. (2013-02-01 12:11:19 UTC) #2
Andrey Novikov
All done, merged, commited http://codereview.adblockplus.org/9316018/diff/1/AndroidManifest.xml File AndroidManifest.xml (right): http://codereview.adblockplus.org/9316018/diff/1/AndroidManifest.xml#newcode21 AndroidManifest.xml:21: android:allowBackup="true" On 2013/02/01 12:11:19, Felix ...
Feb. 2, 2013, 9:58 a.m. (2013-02-02 09:58:30 UTC) #3
Felix Dahlke
Feb. 5, 2013, 3:14 p.m. (2013-02-05 15:14:48 UTC) #4
On 2013/02/02 09:58:30, Andrey Novikov wrote:
> All done, merged, commited

Didn't upload a new patch set? Well I believe you, LGTM :)

Powered by Google App Engine
This is Rietveld