Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9355011: Make sure ABP category cannot be removed (work-around for AVG toolbar issue) (Closed)

Created:
Feb. 7, 2013, 12:43 p.m. by Wladimir Palant
Modified:
Feb. 8, 2013, 8:25 a.m.
Reviewers:
Thomas Greiner
Visibility:
Public.

Description

Make sure ABP category cannot be removed (work-around for AVG toolbar issue)

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M lib/contentPolicy.js View 1 2 chunks +28 lines, -3 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Feb. 7, 2013, 12:43 p.m. (2013-02-07 12:43:41 UTC) #1
Thomas Greiner
http://codereview.adblockplus.org/9355011/diff/1/lib/contentPolicy.js File lib/contentPolicy.js (right): http://codereview.adblockplus.org/9355011/diff/1/lib/contentPolicy.js#newcode385 lib/contentPolicy.js:385: Services.obs.removeObserver(this, "xpcom-category-entry-removed", true); removeObserver doesn't require a third parameter ...
Feb. 7, 2013, 4:16 p.m. (2013-02-07 16:16:27 UTC) #2
Wladimir Palant
Thanks a lot for the thorough review! All comments but the one below have been ...
Feb. 8, 2013, 7:52 a.m. (2013-02-08 07:52:31 UTC) #3
Thomas Greiner
Feb. 8, 2013, 8:09 a.m. (2013-02-08 08:09:10 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld