Issue 9425007: Remove website development VM

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9425007: Remove website development VM (Closed)

Created:
Feb. 20, 2013, 3:53 p.m. by Felix Dahlke

Modified:
Nov. 8, 2013, 8:06 a.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

As discussed earlier, I'm moving the website development VM out of our infrastructure, and into the anwiki repository. I haven't changed really changed the configuration, just moved it. This is the issue removing it from infrastructure: http://codereview.adblockplus.org/9432008/

Patch Set 1 #

Total comments: 2

Created: Feb. 20, 2013, 3:53 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -469 lines)			Patch
M	README.md	View	2 chunks	+3 lines, -61 lines	0 comments	Download
M	Vagrantfile	View	1 chunk	+0 lines, -10 lines	2 comments	Download
M	manifests/monitoringserver.pp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	manifests/nodes.pp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	manifests/vagrant.pp	View	1 chunk	+0 lines, -1 line	0 comments	Download
R	manifests/webserver.pp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
R	modules/adblockplusorg/files/_anwiki-override.inc.php	View	1 chunk	+0 lines, -56 lines	0 comments	Download
R	modules/adblockplusorg/files/adblockplus.org	View	1 chunk	+0 lines, -127 lines	0 comments	Download
R	modules/adblockplusorg/files/anwiki.cfg.php	View	1 chunk	+0 lines, -12 lines	0 comments	Download
R	modules/adblockplusorg/files/deploy-anwiki	View	1 chunk	+0 lines, -60 lines	0 comments	Download
R	modules/adblockplusorg/manifests/init.pp	View	1 chunk	+0 lines, -132 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Wladimir Palant

http://codereview.adblockplus.org/9425007/diff/1/Vagrantfile File Vagrantfile (left): http://codereview.adblockplus.org/9425007/diff/1/Vagrantfile#oldcode24 Vagrantfile:24: yield(config) if block_given? Don't we need that for server10 ...

Feb. 21, 2013, 12:19 p.m. (2013-02-21 12:19:28 UTC) #2

Felix Dahlke

Feb. 21, 2013, 12:20 p.m. (2013-02-21 12:20:47 UTC) #3

Wladimir Palant

Feb. 21, 2013, 12:47 p.m. (2013-02-21 12:47:53 UTC) #4

On 2013/02/21 12:20:47, Felix H. Dahlke wrote:
> That's true, I'll leave it in. Not a fan of unused code, but I guess it's
useful
> anyway.

LGTM if you leave that code in.

Expand All Messages | Collapse All Messages