Issue 9425039: Make sure timezone changes actually take effect

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9425039: Make sure timezone changes actually take effect (Closed)

Created:
Feb. 21, 2013, 4:28 p.m. by Wladimir Palant

Modified:
Nov. 8, 2013, 8:06 a.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Description

Make sure timezone changes actually take effect

Patch Set 1 #

Total comments: 2

Created: Feb. 21, 2013, 4:28 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	modules/base/manifests/init.pp	View		1 chunk	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Wladimir Palant

http://codereview.adblockplus.org/9425039/diff/1/modules/base/manifests/init.pp File modules/base/manifests/init.pp (right): http://codereview.adblockplus.org/9425039/diff/1/modules/base/manifests/init.pp#newcode23 modules/base/manifests/init.pp:23: source => 'puppet:///modules/base/timezone' Looking at this, using content => ...

Feb. 21, 2013, 4:38 p.m. (2013-02-21 16:38:18 UTC) #2

Felix Dahlke

Feb. 22, 2013, 8:20 a.m. (2013-02-22 08:20:26 UTC) #3

LGTM, I think you should address your own comment though :)

http://codereview.adblockplus.org/9425039/diff/1/modules/base/manifests/init.pp
File modules/base/manifests/init.pp (right):

http://codereview.adblockplus.org/9425039/diff/1/modules/base/manifests/init....
modules/base/manifests/init.pp:23: source => 'puppet:///modules/base/timezone'
On 2013/02/21 16:38:19, Wladimir Palant wrote:
> Looking at this, using content => 'UTC' probably makes more sense here.

Yes, that'd be clearer.

Expand All Messages | Collapse All Messages