Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9433002: ABP/Android Proxy settings user helper (Closed)

Created:
Feb. 20, 2013, 8:49 a.m. by Andrey Novikov
Modified:
March 13, 2013, 8:40 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

ABP/Android Proxy settings user helper

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -34 lines) Patch
M AndroidManifest.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M res/layout/configuration.xml View 1 chunk +3 lines, -2 lines 0 comments Download
M res/layout/preferences.xml View 1 chunk +20 lines, -3 lines 0 comments Download
A res/layout/proxyconfiguration.xml View 1 chunk +36 lines, -0 lines 3 comments Download
A res/raw/proxysettings.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M res/values/strings.xml View 3 chunks +5 lines, -2 lines 0 comments Download
M src/org/adblockplus/android/AboutDialog.java View 1 chunk +2 lines, -19 lines 0 comments Download
M src/org/adblockplus/android/AdblockPlus.java View 2 chunks +18 lines, -0 lines 0 comments Download
M src/org/adblockplus/android/ConfigurationActivity.java View 3 chunks +15 lines, -4 lines 0 comments Download
M src/org/adblockplus/android/Preferences.java View 3 chunks +14 lines, -4 lines 0 comments Download
A src/org/adblockplus/android/ProxyConfigurationActivity.java View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Andrey Novikov
Feb. 20, 2013, 8:50 a.m. (2013-02-20 08:50:30 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/9433002/diff/1/res/layout/proxyconfiguration.xml File res/layout/proxyconfiguration.xml (right): http://codereview.adblockplus.org/9433002/diff/1/res/layout/proxyconfiguration.xml#newcode27 res/layout/proxyconfiguration.xml:27: android:text="@string/gotit" /> That button is a bit confusing in ...
Feb. 22, 2013, 11:01 a.m. (2013-02-22 11:01:54 UTC) #2
Andrey Novikov
http://codereview.adblockplus.org/9433002/diff/1/res/layout/proxyconfiguration.xml File res/layout/proxyconfiguration.xml (right): http://codereview.adblockplus.org/9433002/diff/1/res/layout/proxyconfiguration.xml#newcode27 res/layout/proxyconfiguration.xml:27: android:text="@string/gotit" /> On 2013/02/22 11:01:54, Felix H. Dahlke wrote: ...
Feb. 22, 2013, 11:32 a.m. (2013-02-22 11:32:57 UTC) #3
Felix Dahlke
http://codereview.adblockplus.org/9433002/diff/1/res/layout/proxyconfiguration.xml File res/layout/proxyconfiguration.xml (right): http://codereview.adblockplus.org/9433002/diff/1/res/layout/proxyconfiguration.xml#newcode27 res/layout/proxyconfiguration.xml:27: android:text="@string/gotit" /> On 2013/02/22 11:32:57, Andrey Novikov wrote: > ...
Feb. 22, 2013, 11:39 a.m. (2013-02-22 11:39:34 UTC) #4
Felix Dahlke
March 13, 2013, 8:20 a.m. (2013-03-13 08:20:11 UTC) #5
LGTM for this, I changed the parts I didn't like :D

http://codereview.adblockplus.org/9643003/

Powered by Google App Engine
This is Rietveld