Issue 9433005: ABP/Android Port travel

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9433005: ABP/Android Port travel (Closed)

Created:
Feb. 20, 2013, 12:36 p.m. by Andrey Novikov

Modified:
Feb. 20, 2013, 12:51 p.m.

Reviewers:
Felix Dahlke

Visibility:
Public.

Patch Set 1 #

Total comments: 5

Created: Feb. 20, 2013, 12:36 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -20 lines)			Patch
	M	res/values/integers.xml	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	src/org/adblockplus/android/ProxyService.java	View		5 chunks	+17 lines, -19 lines	5 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Felix Dahlke

http://codereview.adblockplus.org/9433005/diff/1/src/org/adblockplus/android/ProxyService.java File src/org/adblockplus/android/ProxyService.java (left): http://codereview.adblockplus.org/9433005/diff/1/src/org/adblockplus/android/ProxyService.java#oldcode659 src/org/adblockplus/android/ProxyService.java:659: Log.e(TAG, "V: " + nativeProxy + " " + ...

Feb. 20, 2013, 12:39 p.m. (2013-02-20 12:39:02 UTC) #2

Andrey Novikov

Feb. 20, 2013, 12:44 p.m. (2013-02-20 12:44:23 UTC) #3

Felix Dahlke

Feb. 20, 2013, 12:50 p.m. (2013-02-20 12:50:41 UTC) #4

LGTM

http://codereview.adblockplus.org/9433005/diff/1/src/org/adblockplus/android/...
File src/org/adblockplus/android/ProxyService.java (right):

http://codereview.adblockplus.org/9433005/diff/1/src/org/adblockplus/android/...
src/org/adblockplus/android/ProxyService.java:75: private static final int[]
portVariants = new int[] {8080, 8888, 1111, 2222, 3333, 4444, 5555, 6666, 7777,
9999, 26571, 0};
On 2013/02/20 12:44:23, Andrey Novikov wrote:
> It was there historically - because first versions had it configurable. This
was
> the default value for preferences. As you can see I have removed preference
> reading code.

Right, still wondering if we should put magic values like that in resources or
not. Don't see a big advantage, it's up to you.

Expand All Messages | Collapse All Messages