Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9453112: Update puppet-postgresql and remove unless (Closed)

Created:
Feb. 28, 2013, 5:11 p.m. by Felix Dahlke
Modified:
Nov. 12, 2013, 9:56 a.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

I've fixed the issue with the puppet-postgresql module which caused us to add the unless => 'SELECT false' as a workaround. That workaround doesn't seem to work on fresh provisions, or at least not for me. Here's the pull request for puppet-postgresql: https://github.com/puppetlabs/puppet-postgresql/pull/144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M .hgsub View 1 chunk +1 line, -0 lines 0 comments Download
M modules/discourse/manifests/admin.pp View 1 chunk +2 lines, -4 lines 0 comments Download
M modules/discourse/manifests/postactiontype.pp View 1 chunk +2 lines, -4 lines 0 comments Download
M modules/discourse/manifests/sitesetting.pp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6
Felix Dahlke
Feb. 28, 2013, 5:14 p.m. (2013-02-28 17:14:34 UTC) #1
Wladimir Palant
LGTM but you might want to use the simpler puppet-postgresql fix.
April 3, 2013, 2:48 p.m. (2013-04-03 14:48:34 UTC) #2
Felix Dahlke
On 2013/04/03 14:48:34, Wladimir Palant wrote: > LGTM but you might want to use the ...
April 3, 2013, 4:18 p.m. (2013-04-03 16:18:41 UTC) #3
Wladimir Palant
Yes, the suggestion to use false rather than :false sounds like the right thing to ...
April 3, 2013, 7:21 p.m. (2013-04-03 19:21:47 UTC) #4
Felix Dahlke
On 2013/04/03 19:21:47, Wladimir Palant wrote: > Yes, the suggestion to use false rather than ...
April 4, 2013, 2:25 a.m. (2013-04-04 02:25:57 UTC) #5
Felix Dahlke
June 4, 2013, 3:11 p.m. (2013-06-04 15:11:33 UTC) #6
On 2013/04/04 02:25:57, Felix H. Dahlke wrote:
> On 2013/04/03 19:21:47, Wladimir Palant wrote:
> > Yes, the suggestion to use false rather than :false sounds like the right
> thing
> > to do. Not that I know Ruby enough to be sure myself...
> 
> It's not a Ruby thing, :false is just a keyword (which are arbitrary, like a
> string, and can in fact be converted to/from strings). How I implemented it,
we
> can use any of false, "false" or :false in manifests. I did get the impression
> that's how it's supposed to be.

Well, since that's what the docs say, and since that guy won't merge it
otherwise, and since it works for us anyway, I simplified things. I wasn't able
to figure out enough about booleans in Puppet to know how they're supposed to be
handled.

Powered by Google App Engine
This is Rietveld