Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 9570024: ABP/Android Fix crash on unescaped uri (Closed)

Created:
March 6, 2013, 2:55 p.m. by Andrey Novikov
Modified:
March 7, 2013, 10:13 a.m.
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

ABP/Android Fix crash on unescaped uri

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M jni/jsEngine.cpp View 1 chunk +10 lines, -1 line 1 comment Download
M src/org/adblockplus/android/AdblockPlus.java View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2
Andrey Novikov
March 6, 2013, 2:55 p.m. (2013-03-06 14:55:20 UTC) #1
Felix Dahlke
March 6, 2013, 3:06 p.m. (2013-03-06 15:06:35 UTC) #2
http://codereview.adblockplus.org/9570024/diff/1/jni/jsEngine.cpp
File jni/jsEngine.cpp (right):

http://codereview.adblockplus.org/9570024/diff/1/jni/jsEngine.cpp#newcode169
jni/jsEngine.cpp:169: v8::TryCatch try_catch;
You could just use the same TryCatch for both Compile and Run. Anyway, LGTM.

Powered by Google App Engine
This is Rietveld