Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 9615013: Crawler, first version (Closed)

Created:
March 6, 2013, 4:05 a.m. by Eric
Modified:
June 12, 2013, 2:18 p.m.
Visibility:
Public.

Description

Crawler, first version

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6347 lines, -259 lines) Patch
M .hgignore View 1 chunk +3 lines, -0 lines 2 comments Download
M .hgsubstate View 1 chunk +1 line, -1 line 0 comments Download
M README.md View 1 chunk +3 lines, -3 lines 0 comments Download
R chrome/content/crawler.js View 1 chunk +0 lines, -74 lines 0 comments Download
M chrome/content/crawler.xul View 1 chunk +188 lines, -31 lines 0 comments Download
A chrome/content/crawler_ui.js View 1 chunk +355 lines, -0 lines 0 comments Download
A chrome/content/sandbox_ui.js View 1 chunk +230 lines, -0 lines 0 comments Download
A chrome/content/task_test_ui.js View 1 chunk +109 lines, -0 lines 0 comments Download
M chrome/locale/en-US/crawler.dtd View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/skin/dialog-cancel-3.png View Binary file 0 comments Download
A chrome/skin/folder.png View Binary file 0 comments Download
A chrome/skin/text-x-source.png View Binary file 0 comments Download
A lib/browser.js View 1 chunk +457 lines, -0 lines 0 comments Download
M lib/client.js View 1 chunk +2 lines, -2 lines 0 comments Download
A lib/counter_task.js View 1 chunk +117 lines, -0 lines 0 comments Download
M lib/crawler.js View 1 chunk +578 lines, -112 lines 0 comments Download
A lib/encoding.js View 1 chunk +1145 lines, -0 lines 0 comments Download
A lib/instruction.js View 1 chunk +441 lines, -0 lines 0 comments Download
A lib/logger.js View 1 chunk +142 lines, -0 lines 0 comments Download
M lib/storage.js View 1 chunk +200 lines, -32 lines 0 comments Download
A lib/task.js View 1 chunk +305 lines, -0 lines 0 comments Download
A lib/yaml.js View 1 chunk +2068 lines, -0 lines 0 comments Download
M metadata.gecko View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6
Eric
Ready to review. Used upload.py to create, not the hgreview extension.
March 6, 2013, 4:10 a.m. (2013-03-06 04:10:00 UTC) #1
Felix Dahlke
Just one small comment so far. Before we continue the review, can you change indentation ...
March 11, 2013, 7:01 a.m. (2013-03-11 07:01:35 UTC) #2
Eric
On 2013/03/11 07:01:35, Felix H. Dahlke wrote: > Just one small comment so far. Before ...
March 11, 2013, 2:41 p.m. (2013-03-11 14:41:41 UTC) #3
Eric
http://codereview.adblockplus.org/9615013/diff/1/.hgignore File .hgignore (right): http://codereview.adblockplus.org/9615013/diff/1/.hgignore#newcode7 .hgignore:7: lib/storage@98.js On 2013/03/11 07:01:35, Felix H. Dahlke wrote: > ...
March 11, 2013, 2:42 p.m. (2013-03-11 14:42:44 UTC) #4
Eric
On 2013/03/06 04:10:00, Eric wrote: > Ready to review. Superseded by the second version http://codereview.adblockplus.org/10233013/
April 12, 2013, 1:41 p.m. (2013-04-12 13:41:38 UTC) #5
Felix Dahlke
June 6, 2013, 5:44 p.m. (2013-06-06 17:44:58 UTC) #6 
On 2013/04/12 13:41:38, Eric wrote:
> On 2013/03/06 04:10:00, Eric wrote:
> > Ready to review.
> 
> Superseded by the second version http://codereview.adblockplus.org/10233013/

I guess this can be closed.

Powered by Google App Engine
This is Rietveld