ABP/Android Remember lart port used

This can hardly happen but it's a good style not to switch ports if one was already selected so that user will not have to reconfigure everything.

[Felix Dahlke, 2013-03-13 13:16:49]

Good idea, just one nit.

http://codereview.adblockplus.org/9811019/diff/1/src/org/adblockplus/android/...
File src/org/adblockplus/android/ProxyService.java (right):

http://codereview.adblockplus.org/9811019/diff/1/src/org/adblockplus/android/...
src/org/adblockplus/android/ProxyService.java:231: portVariants[0] =
prefs.getInt(getString(R.string.pref_lastport), -1);
I think it would be more elegant here to convert the array to a List and add an
element to the front there. Means we wouldn't have to deal with -1.

[Andrey Novikov, 2013-03-13 13:22:38]

http://codereview.adblockplus.org/9811019/diff/1/src/org/adblockplus/android/...
File src/org/adblockplus/android/ProxyService.java (right):

http://codereview.adblockplus.org/9811019/diff/1/src/org/adblockplus/android/...
src/org/adblockplus/android/ProxyService.java:231: portVariants[0] =
prefs.getInt(getString(R.string.pref_lastport), -1);
This was the first what I thought about but constructing dynamic array just for
one push is redundant imho.

[Felix Dahlke, 2013-03-13 13:24:57]

http://codereview.adblockplus.org/9811019/diff/1/src/org/adblockplus/android/...
File src/org/adblockplus/android/ProxyService.java (right):

http://codereview.adblockplus.org/9811019/diff/1/src/org/adblockplus/android/...
src/org/adblockplus/android/ProxyService.java:231: portVariants[0] =
prefs.getInt(getString(R.string.pref_lastport), -1);
On 2013/03/13 13:22:38, Andrey Novikov wrote:
> This was the first what I thought about but constructing dynamic array just
for
> one push is redundant imho. 

But it's less error-prone (this would fall apart if you try and move -1 to a
different position above), and since this part is clearly not that performance
sensitive...

[Felix Dahlke, 2013-06-04 13:34:56]

So I take it you'd rather not implement my suggestion?

Well, it's just a nit, so LGTM, we can close this.

[Felix Dahlke, 2013-09-11 13:31:49]

On 2013/06/04 13:34:56, Felix H. Dahlke wrote:
> So I take it you'd rather not implement my suggestion?
> 
> Well, it's just a nit, so LGTM, we can close this.

Can you close this, Andrey?