Always use the system language for the UI

This change makes the UI language always equal to the system language, it'll default to English if the translation is missing.

While I was at it, I also made ABP initially select a subscription based on the system language, assuming we want this to behave like ABP.

[Oleksandr, 2013-03-22 16:04:14]

http://codereview.adblockplus.org/9843129/diff/1/Shared/PluginClientBase.cpp
File Shared/PluginClientBase.cpp (right):

http://codereview.adblockplus.org/9843129/diff/1/Shared/PluginClientBase.cpp#...
Shared/PluginClientBase.cpp:101: settings->SetString(SETTING_LANGUAGE,
browserLanguage);
What if we don't have the browser's version in the dictionary? The value in the
setting's file would be a bit misleading imho. Maybe we should still default to
"en" more gracefuly? Also, what if the user changes the browser language after
we have initially set it. Shall we change as well?

[Felix Dahlke, 2013-03-22 16:09:18]

http://codereview.adblockplus.org/9843129/diff/1/Shared/PluginClientBase.cpp
File Shared/PluginClientBase.cpp (right):

http://codereview.adblockplus.org/9843129/diff/1/Shared/PluginClientBase.cpp#...
Shared/PluginClientBase.cpp:101: settings->SetString(SETTING_LANGUAGE,
browserLanguage);
On 2013/03/22 16:04:14, Oleksandr wrote:
> What if we don't have the browser's version in the dictionary? The value in
the
> setting's file would be a bit misleading imho. Maybe we should still default
to
> "en" more gracefuly?

Hehe, I've wondered quite a bit about this actually. I thought it's better to
put the actual language into the settings file, but since that's an illegal
value as far as the settings are concerned, it may really be misleading. The
question is: is the result of dic->IsLanguageSupported() actually related to
what _filters_ we offer? I thought not.

> Also, what if the user changes the browser language after
> we have initially set it. Shall we change as well?

No, I don't think so. We select a subscription based on the user's language,
from then on he's on his own. That's how the other extensions do it if I'm not
mistaken.

[Oleksandr, 2013-03-22 16:15:28]

LGTM

http://codereview.adblockplus.org/9843129/diff/1/Shared/PluginClientBase.cpp
File Shared/PluginClientBase.cpp (right):

http://codereview.adblockplus.org/9843129/diff/1/Shared/PluginClientBase.cpp#...
Shared/PluginClientBase.cpp:101: settings->SetString(SETTING_LANGUAGE,
browserLanguage);
On 2013/03/22 16:09:18, Felix H. Dahlke wrote:
> On 2013/03/22 16:04:14, Oleksandr wrote:
> > What if we don't have the browser's version in the dictionary? The value in
> the
> > setting's file would be a bit misleading imho. Maybe we should still default
> to
> > "en" more gracefuly?
> 
> Hehe, I've wondered quite a bit about this actually. I thought it's better to
> put the actual language into the settings file, but since that's an illegal
> value as far as the settings are concerned, it may really be misleading. The
> question is: is the result of dic->IsLanguageSupported() actually related to
> what _filters_ we offer? I thought not.

It isn't related, but it's not like we can have one that is related :) I guess
at some point of time we can implement IsLanguageFilterSupported or something
like that. Probably not important right now.

> > Also, what if the user changes the browser language after
> > we have initially set it. Shall we change as well?
> 
> No, I don't think so. We select a subscription based on the user's language,
> from then on he's on his own. That's how the other extensions do it if I'm not
> mistaken.

LGTM then